Skip to content

⚡️ Speed up method JournalStorageReplayResult.get_all_trials by 21% #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up method JournalStorageReplayResult.get_all_trials by 21% #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions optuna/storages/journal/_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,12 +461,16 @@ def get_all_trials(
if study_id not in self._studies:
raise KeyError(NOT_FOUND_MSG)

frozen_trials: list[FrozenTrial] = []
for trial_id in self._study_id_to_trial_ids[study_id]:
trial = self._trials[trial_id]
if states is None or trial.state in states:
frozen_trials.append(trial)
return frozen_trials
trial_ids = self._study_id_to_trial_ids[study_id]
trials = self._trials
if states is None:
return [trials[trial_id] for trial_id in trial_ids]
states_set = states if isinstance(states, set) else set(states)
return [
trial
for trial_id in trial_ids
if (trial := trials[trial_id]).state in states_set
]

@property
def worker_id(self) -> str:
Expand Down