Skip to content

CM4 Direction for throttle_time_ms Mismatch #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Spiderpig86 opened this issue Oct 27, 2024 · 1 comment · Fixed by codecrafters-io/build-your-own-kafka#16
Closed
Assignees

Comments

@Spiderpig86
Copy link

The directions mention that any throttle_time_ms is accepted

- The `throttle_time_ms` field in the response is present (any value is accepted).
)

But the test case strictly asserts it is 0

ThrottleTimeMs: 0,

This is reproducible by modifying the response throttle_time_ms to a non-zero value.

@Spiderpig86 Spiderpig86 changed the title CM4 Direction Mismatch CM4 Direction for throttle_time_ms Mismatch Oct 27, 2024
@ryan-gang ryan-gang self-assigned this Oct 28, 2024
@ryan-gang
Copy link
Contributor

Thanks, @Spiderpig86, for highlighting the issue! We've fixed it in codecrafters-io/build-your-own-kafka#16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants