Skip to content
This repository was archived by the owner on Mar 29, 2023. It is now read-only.

Conversation

@jayj
Copy link

@jayj jayj commented Mar 18, 2020

Hi,

This PR adds support for splashscreens added using Launch storyboard images. Without this it just shows an black screen on iOS in the app switcher.

Uses the same way to the get image as the Cordova Splash screen plugin: (https://github.com/apache/cordova-plugin-splashscreen/blob/rel/5.0.3/src/ios/CDVSplashScreen.m#L196-L200)

UIViewContentModeScaleAspectFill ensures the aspect ratio is correct (https://github.com/apache/cordova-plugin-splashscreen/blob/rel/5.0.3/src/ios/CDVSplashScreen.m#L360-L366)

@asolntsev
Copy link
Member

asolntsev commented Mar 20, 2020

@jayj Thank you for the contribution!
Sorry, we don't actively maintain those plugins. Maybe we will review pull requests when we get back to office from quarantine.

@jayj
Copy link
Author

jayj commented Mar 20, 2020

Thanks @asolntsev

That's fine! I'll just keep using my fork.
Launch storyboard images seems to be new recommended way by Cordova to add splash screens now so if someone else needs this change my fork is at: https://github.com/jayj/cordova-plugin-privacyscreen/tree/master

@WuglyakBolgoink
Copy link

@asolntsev / @jayj

same as support new android-x...

@asolntsev any update for a new release?

@asolntsev
Copy link
Member

@WuglyakBolgoink Sorry, no news. We still don't plan to maintain Cordova plugins.
We recently switched to native mobile applications, so you would better support your own fork..

@WuglyakBolgoink
Copy link

@asolntsev ok, good to know

@WuglyakBolgoink
Copy link

then, for everyone who need this fix, please use my fork

https://github.com/WuglyakBolgoink/cordova-plugin-privacyscreen

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants