fix(types): handle reasoning.encrypted content block type from Grok models by potb · Pull Request #1732 · code-yeongyu/oh-my-opencode

potb · 2026-02-10T17:49:49Z

Grok models return reasoning.encrypted content blocks. We only check for "reasoning" and "thinking", so these blocks get silently dropped during validation, extraction, and formatting.

Added reasoning.encrypted to the ThinkingPartType union and THINKING_TYPES set, then updated all downstream checks. Content extraction guards on && part.text so encrypted blocks without text are safely skipped.

cubic-dev-ai

3 issues found across 14 files

Confidence score: 4/5

This PR looks generally safe to merge, but there is a user-facing risk: reasoning.encrypted parts are filtered out before formatting in src/tools/background-task/full-session-format.ts and src/tools/background-task/modules/formatters.ts, so the new handling is unreachable and content gets dropped even when includeThinking is true.
The test in src/hooks/thinking-block-validator/reasoning-encrypted.test.ts is tautological and doesn’t exercise production logic, so it won’t catch regressions in the validator.
Pay close attention to src/tools/background-task/full-session-format.ts, src/tools/background-task/modules/formatters.ts, src/hooks/thinking-block-validator/reasoning-encrypted.test.ts - reasoning.encrypted handling is dropped and test coverage is ineffective.

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/hooks/thinking-block-validator/reasoning-encrypted.test.ts">

<violation number="1" location="src/hooks/thinking-block-validator/reasoning-encrypted.test.ts:5">
P2: Test is tautological: it only checks a locally defined helper instead of exercising production logic, so it provides no real coverage of the thinking-block validator.</violation>
</file>

<file name="src/tools/background-task/full-session-format.ts">

<violation number="1" location="src/tools/background-task/full-session-format.ts:138">
P2: `reasoning.encrypted` parts are filtered out before formatting, so the newly added handling is unreachable and the content is discarded.</violation>
</file>

<file name="src/tools/background-task/modules/formatters.ts">

<violation number="1" location="src/tools/background-task/modules/formatters.ts:305">
P2: `reasoning.encrypted` parts are filtered out before formatting, so the newly added handling is unreachable and these parts are dropped even when `includeThinking` is true.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/hooks/thinking-block-validator/reasoning-encrypted.test.ts

src/tools/background-task/full-session-format.ts

src/tools/background-task/modules/formatters.ts

…NKING_TYPES Set Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

…traction Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

…g content extraction Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

The filter that normalizes message parts before formatting only checked for 'thinking' and 'reasoning', so reasoning.encrypted parts were silently dropped even when includeThinking was true.

potb · 2026-02-10T18:48:31Z

@cubic-dev-ai recheck

cubic-dev-ai · 2026-02-10T18:48:38Z

@cubic-dev-ai recheck

@potb I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 13 files

Confidence score: 5/5

Low-severity test quality concern only; no concrete user-facing regression is indicated, so this looks safe to merge.
src/hooks/thinking-block-validator/reasoning-encrypted.test.ts validates a local helper instead of production logic, so the test could pass even if the real thinking-family check is wrong.
Pay close attention to src/hooks/thinking-block-validator/reasoning-encrypted.test.ts - test may not exercise actual production behavior.

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="src/hooks/thinking-block-validator/reasoning-encrypted.test.ts">

<violation number="1" location="src/hooks/thinking-block-validator/reasoning-encrypted.test.ts:5">
P3: This test defines and validates a local helper instead of exercising production logic, so it will pass even if the real thinking-family check is incorrect (e.g., `startsWithThinkingBlock` still ignores `reasoning.encrypted`). It doesn’t provide regression protection for the intended change.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

src/hooks/thinking-block-validator/reasoning-encrypted.test.ts

…thThinkingBlock and findPreviousThinkingContent Address review feedback (identified by cubic): the thinking-block-validator hook was missing reasoning.encrypted in two internal functions, and the test was tautological (testing a local helper instead of production logic). - Add reasoning.encrypted to startsWithThinkingBlock so messages starting with encrypted reasoning are recognized as having a thinking block - Add reasoning.encrypted to findPreviousThinkingContent so encrypted reasoning from prior turns can be recovered - Rewrite test to exercise createThinkingBlockValidatorHook directly with message fixtures instead of a locally defined helper

code-yeongyu · 2026-02-14T02:44:57Z

Thank you for the thorough effort across 14 files — this was clearly a lot of careful work!

After investigating the OpenCode source code, we found that reasoning.encrypted is not actually a part type that OpenCode emits. What exists in the OpenCode codebase is:

"reasoning" — the actual part type (always set to "reasoning" regardless of encryption)
"reasoning.encrypted_content" — an OpenAI Responses API include parameter value (tells the API to return encrypted reasoning)
encrypted_content — a field on reasoning parts (part.encrypted_content)

The message processor in OpenCode (src/session/processor.ts) always sets the part type to "reasoning", even for encrypted reasoning blocks. So the plugin code already handles these correctly without needing a separate "reasoning.encrypted" check.

We really appreciate you taking the time to look into Grok model compatibility — that kind of cross-model thinking is exactly what we need. Thank you! 🙏

cubic-dev-ai bot reviewed Feb 10, 2026

View reviewed changes

src/hooks/thinking-block-validator/reasoning-encrypted.test.ts Outdated Show resolved Hide resolved

src/tools/background-task/full-session-format.ts Show resolved Hide resolved

src/tools/background-task/modules/formatters.ts Show resolved Hide resolved

potb marked this pull request as draft February 10, 2026 18:08

potb force-pushed the fix/1588-reasoning-encrypted branch from 4aec122 to d45b87f Compare February 10, 2026 18:16

potb and others added 5 commits February 10, 2026 19:21

fix(types): add reasoning.encrypted to ThinkingPartType union and THI…

709c4ee

…NKING_TYPES Set Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

fix(hooks): handle reasoning.encrypted in thinking-family checks

9399c37

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

fix(background-task): handle reasoning.encrypted in content extraction

df8124c

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

fix(delegate-task): handle reasoning.encrypted in sync task result ex…

f8cc7d7

…traction Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

fix(unstable-agent-babysitter): handle reasoning.encrypted in thinkin…

f634150

…g content extraction Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <[email protected]>

potb force-pushed the fix/1588-reasoning-encrypted branch from d45b87f to f634150 Compare February 10, 2026 18:23

fix(background-task): include reasoning.encrypted in part type filters

40f0a68

The filter that normalizes message parts before formatting only checked for 'thinking' and 'reasoning', so reasoning.encrypted parts were silently dropped even when includeThinking was true.

cubic-dev-ai bot reviewed Feb 10, 2026

View reviewed changes

src/hooks/thinking-block-validator/reasoning-encrypted.test.ts Outdated Show resolved Hide resolved

potb changed the title ~~fix(types): handle reasoning.encrypted content block type from Grok models (#1588)~~ fix(types): handle reasoning.encrypted content block type from Grok models Feb 10, 2026

code-yeongyu closed this Feb 14, 2026

potb deleted the fix/1588-reasoning-encrypted branch February 14, 2026 12:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): handle reasoning.encrypted content block type from Grok models#1732

fix(types): handle reasoning.encrypted content block type from Grok models#1732
potb wants to merge 7 commits intocode-yeongyu:devfrom
potb:fix/1588-reasoning-encrypted

potb commented Feb 10, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

potb commented Feb 10, 2026

Uh oh!

cubic-dev-ai bot commented Feb 10, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

code-yeongyu commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

potb commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

potb commented Feb 10, 2026

Uh oh!

cubic-dev-ai bot commented Feb 10, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

code-yeongyu commented Feb 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

potb commented Feb 10, 2026 •

edited

Loading