chore(perf-issues): Remove some detector flags (getsentry#90488)

The Consecutive HTTP and Large Payload Detectors checked flags for their
rollout that were never GA'd even though they were marked
`released=True` implying users could see them. This removes the check on
those flags, **but doesn't GA them** just yet.

They will still exit in `is_creation_allowed_for_system`
([source](https://github.com/getsentry/sentry/blob/master/src/sentry/utils/performance_issues/base.py#L98-L112))
since the registered flag is set to 0.0 (see this PR -
getsentry#90486)

Author: leeandher

src/sentry/apidocs/examples/project_examples.py

@@ -187,120 +187,11 @@
         "require2FA": False,
         "avatar": {"avatarType": "upload", "avatarUuid": "24f6f762f7a7473888b259c566da5adb"},
         "features": [
-            "performance-uncompressed-assets-ingest",
-            "dashboards-rh-widget",
-            "performance-db-main-thread-visible",
-            "transaction-name-mark-scrubbed-as-sanitized",
-            "sentry-pride-logo-footer",
-            "issue-list-prefetch-issue-on-hover",
-            "mep-rollout-flag",
-            "performance-issues-m-n-plus-one-db-detector",
-            "session-replay-ui",
-            "alert-crash-free-metrics",
-            "performance-n-plus-one-db-queries-visible",
-            "session-replay-recording-scrubbing",
-            "profile-file-io-main-thread-visible",
-            "performance-consecutive-http-detector",
-            "profiling",
-            "symbol-sources",
-            "advanced-search",
-            "performance-n-plus-one-db-queries-post-process-group",
-            "minute-resolution-sessions",
-            "performance-transaction-name-only-search-indexed",
-            "performance-large-http-payload-detector",
-            "performance-consecutive-db-queries-ingest",
-            "business-to-team-promotion",
-            "shared-issues",
-            "performance-large-http-payload-post-process-group",
-            "promotion-be-adoption-enabled",
+            "global-views",
+            "discover-basic",
+            "incidents",
+            "uptime",
             "monitors",
-            "am2-billing",
-            "profiling-ga",
-            "performance-new-trends",
-            "performance-n-plus-one-api-calls-post-process-group",
-            "performance-db-main-thread-post-process-group",
-            "performance-metrics-backed-transaction-summary",
-            "issue-platform",
-            "performance-consecutive-db-issue",
-            "performance-consecutive-http-post-process-group",
-            "performance-n-plus-one-api-calls-detector",
-            "performance-render-blocking-asset-span-post-process-group",
-            "performance-uncompressed-assets-post-process-group",
-            "performance-slow-db-issue",
-            "performance-db-main-thread-ingest",
-            "session-replay",
-            "sql-format",
-            "performance-consecutive-db-queries-visible",
-            "user-spend-notifications-settings",
-            "performance-m-n-plus-one-db-queries-post-process-group",
-            "transaction-metrics-extraction",
-            "performance-consecutive-db-queries-post-process-group",
-            "performance-slow-db-query-post-process-group",
-            "performance-n-plus-one-db-queries-ingest",
-            "profile-image-decode-main-thread-visible",
-            "performance-issues-render-blocking-assets-detector",
-            "performance-m-n-plus-one-db-queries-ingest",
-            "anr-rate",
-            "auto-enable-codecov",
-            "ondemand-budgets",
-            "profile-file-io-main-thread-post-process-group",
-            "performance-render-blocking-asset-span-ingest",
-            "profile-json-decode-main-thread-post-process-group",
-            "onboarding-project-deletion-on-back-click",
-            "invite-members-rate-limits",
-            "transaction-name-normalize",
-            "performance-file-io-main-thread-visible",
-            "performance-span-histogram-view",
-            "performance-file-io-main-thread-ingest",
-            "metrics-extraction",
-            "profile-json-decode-main-thread-ingest",
-            "onboarding",
-            "promotion-mobperf-gift50kerr",
-            "device-classification",
-            "transaction-name-normalize-legacy",
-            "performance-slow-db-query-ingest",
-            "bundle-plan-checkout",
-            "metric-alert-chartcuterie",
-            "performance-issues-all-events-tab",
-            "discover-events-rate-limit",
-            "india-promotion",
-            "track-button-click-events",
-            "performance-issues-compressed-assets-detector",
-            "device-class-synthesis",
-            "profiling-billing",
-            "integrations-deployment",
-            "performance-m-n-plus-one-db-queries-visible",
-            "mobile-cpu-memory-in-transactions",
-            "derive-code-mappings",
-            "performance-onboarding-checklist",
-            "performance-consecutive-http-visible",
-            "performance-n-plus-one-api-calls-ingest",
-            "performance-landing-page-stats-period",
-            "dynamic-sampling",
-            "performance-slow-db-query-visible",
-            "performance-n-plus-one-api-calls-visible",
-            "profile-image-decode-main-thread-ingest",
-            "set-grouping-config",
-            "event-attachments",
-            "open-membership",
-            "new-spike-protection",
-            "source-maps-debug-ids",
-            "paid-to-free-promotion",
-            "performance-large-http-payload-ingest",
-            "crons-issue-platform",
-            "profile-file-io-main-thread-ingest",
-            "performance-file-io-main-thread-post-process-group",
-            "performance-render-blocking-asset-span-visible",
-            "ds-sliding-window-org",
-            "performance-consecutive-http-ingest",
-            "profile-image-decode-main-thread-post-process-group",
-            "performance-mep-bannerless-ui",
-            "performance-uncompressed-assets-visible",
-            "performance-large-http-payload-visible",
-            "performance-view",
-            "promotion-mobperf-discount20",
-            "performance-new-widget-designs",
-            "profile-json-decode-main-thread-visible",
         ],
         "links": {
             "organizationUrl": "https://sentry.sentry.io",

src/sentry/utils/performance_issues/detectors/consecutive_http_detector.py

@@ -2,7 +2,6 @@
 
 from typing import Any
 
-from sentry import features
 from sentry.issues.grouptype import PerformanceConsecutiveHTTPQueriesGroupType
 from sentry.issues.issue_occurrence import IssueEvidence
 from sentry.models.organization import Organization
@@ -176,9 +175,7 @@ def on_complete(self) -> None:
         self._validate_and_store_performance_problem()
 
     def is_creation_allowed_for_organization(self, organization: Organization) -> bool:
-        return features.has(
-            "organizations:performance-consecutive-http-detector", organization, actor=None
-        )
+        return True
 
     def is_creation_allowed_for_project(self, project: Project) -> bool:
         return self.settings["detection_enabled"]

src/sentry/utils/performance_issues/detectors/large_payload_detector.py

@@ -4,7 +4,6 @@
 from datetime import timedelta
 from typing import Any
 
-from sentry import features
 from sentry.issues.grouptype import PerformanceLargeHTTPPayloadGroupType
 from sentry.issues.issue_occurrence import IssueEvidence
 from sentry.models.organization import Organization
@@ -130,9 +129,7 @@ def _fingerprint(self, span: Span) -> str:
         return f"1-{PerformanceLargeHTTPPayloadGroupType.type_id}-{hashed_url_paths}"
 
     def is_creation_allowed_for_organization(self, organization: Organization) -> bool:
-        return features.has(
-            "organizations:performance-large-http-payload-detector", organization, actor=None
-        )
+        return True
 
     def is_creation_allowed_for_project(self, project: Project) -> bool:
         return self.settings["detection_enabled"]

tests/sentry/utils/performance_issues/test_performance_detection.py

@@ -301,49 +301,47 @@ def test_boolean_system_option_disables_detector_issue_creation(self):
         event = get_event("consecutive-http/consecutive-http-basic")
         sdk_span_mock = Mock()
 
-        with self.feature("organizations:performance-consecutive-http-detector"):
-            perf_problems = _detect_performance_problems(event, sdk_span_mock, self.project)
-            assert perf_problems == []
+        perf_problems = _detect_performance_problems(event, sdk_span_mock, self.project)
+        assert perf_problems == []
 
     @override_options({"performance.issues.consecutive_http.problem-creation": False})
     def test_boolean_system_option_enables_detector_issue_creation(self):
         event = get_event("consecutive-http/consecutive-http-basic")
         sdk_span_mock = Mock()
 
-        with self.feature("organizations:performance-consecutive-http-detector"):
-            perf_problems = _detect_performance_problems(event, sdk_span_mock, self.project)
-            assert perf_problems == [
-                PerformanceProblem(
-                    fingerprint="1-1009-6654ad4d1d494222ce02c656386e6955575c17ed",
-                    op="http",
-                    desc="GET https://my-api.io/api/users?page=1",
-                    type=PerformanceConsecutiveHTTPQueriesGroupType,
-                    parent_span_ids=None,
-                    cause_span_ids=[],
-                    offender_span_ids=[
+        perf_problems = _detect_performance_problems(event, sdk_span_mock, self.project)
+        assert perf_problems == [
+            PerformanceProblem(
+                fingerprint="1-1009-6654ad4d1d494222ce02c656386e6955575c17ed",
+                op="http",
+                desc="GET https://my-api.io/api/users?page=1",
+                type=PerformanceConsecutiveHTTPQueriesGroupType,
+                parent_span_ids=None,
+                cause_span_ids=[],
+                offender_span_ids=[
+                    "96e0ae187b5481a1",
+                    "8d22b49a27b18270",
+                    "b2bc2ebb42248c74",
+                    "9336922774fd35bc",
+                    "a307ceb77c702cea",
+                    "ac1e90ff646617e7",
+                ],
+                evidence_data={
+                    "op": "http",
+                    "parent_span_ids": None,
+                    "cause_span_ids": [],
+                    "offender_span_ids": [
                         "96e0ae187b5481a1",
                         "8d22b49a27b18270",
                         "b2bc2ebb42248c74",
                         "9336922774fd35bc",
                         "a307ceb77c702cea",
                         "ac1e90ff646617e7",
                     ],
-                    evidence_data={
-                        "op": "http",
-                        "parent_span_ids": None,
-                        "cause_span_ids": [],
-                        "offender_span_ids": [
-                            "96e0ae187b5481a1",
-                            "8d22b49a27b18270",
-                            "b2bc2ebb42248c74",
-                            "9336922774fd35bc",
-                            "a307ceb77c702cea",
-                            "ac1e90ff646617e7",
-                        ],
-                    },
-                    evidence_display=[],
-                )
-            ]
+                },
+                evidence_display=[],
+            )
+        ]
 
     @override_options(BASE_DETECTOR_OPTIONS)
     def test_system_option_used_when_project_option_is_default(self):