Skip to content

Commit 48325ed

Browse files
joshsmithbegedin
authored andcommitted
chore(package): update ember-cli-password-strength to version 2.0.0 (#1490)
* chore(package): update ember-cli-password-strength to version 2.0.0 Closes #1458 * Migrate app to new version of ember-cli-password-strength
1 parent 98ddd4b commit 48325ed

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

app/components/signup-password-input.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import Component from '@ember/component';
2-
import { computed } from '@ember/object';
2+
import { computed, get } from '@ember/object';
33
import { not, lt, gte, alias } from '@ember/object/computed';
44
import { inject as service } from '@ember/service';
5-
import strength from 'password-strength';
65

76
export default Component.extend({
87
classNames: ['input-group'],
98

109
ajax: service(),
10+
passwordStrength: service(),
1111

1212
canShowValidations: alias('isNotEmpty'),
1313
isEmpty: lt('passwordLength', 1),
@@ -23,8 +23,8 @@ export default Component.extend({
2323
}),
2424

2525
strength: computed('password', function() {
26-
let password = this.get('password') || '';
27-
return strength(password);
26+
let passwordStrength = get(this, 'passwordStrength');
27+
return passwordStrength.strengthSync(get(this, 'password'));
2828
}),
2929

3030
strengthPercentage: computed('isValid', 'passwordLength', 'strength', function() {

ember-cli-build.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ module.exports = function(defaults) {
2929
// async, await, etc.
3030
includePolyfill: true
3131
},
32+
'ember-cli-password-strength': {
33+
bundleZxcvbn: true
34+
},
3235
fingerprint: fingerprintOptions,
3336
emberCLIDeploy: {
3437
// runOnPostBuild: (env === 'development') ? 'development-postbuild' : false,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"ember-cli-moment-shim": "^3.4.0",
5151
"ember-cli-neat": "^0.0.6",
5252
"ember-cli-page-object": "1.12.1",
53-
"ember-cli-password-strength": "1.0.3",
53+
"ember-cli-password-strength": "^2.0.0",
5454
"ember-cli-qunit": "^4.1.1",
5555
"ember-cli-release": "^0.2.9",
5656
"ember-cli-sass": "^7.0.0",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3008,13 +3008,13 @@ [email protected]:
30083008
ember-test-helpers "^0.6.3"
30093009
rsvp "^3.2.1"
30103010

3011-
ember-cli-password-strength@1.0.3:
3012-
version "1.0.3"
3013-
resolved "https://registry.yarnpkg.com/ember-cli-password-strength/-/ember-cli-password-strength-1.0.3.tgz#690a7771bbb6e9c4994a73259df4df785a2287df"
3011+
ember-cli-password-strength@^2.0.0:
3012+
version "2.0.0"
3013+
resolved "https://registry.yarnpkg.com/ember-cli-password-strength/-/ember-cli-password-strength-2.0.0.tgz#f6f16d5c42ac16a4605305244f15f092f15224b3"
30143014
dependencies:
30153015
broccoli-funnel "^1.1.0"
30163016
broccoli-merge-trees "^2.0.0"
3017-
ember-cli-babel "^6.0.0"
3017+
ember-cli-babel "^6.8.0"
30183018
zxcvbn "^4.3.0"
30193019

30203020
ember-cli-path-utils@^1.0.0:

0 commit comments

Comments
 (0)