Merge pull request #1686 from code-corps/1685-fix-signup-form-validatio

Fix sign up form validation

Author: joshsmith

app/components/signup-email-input.js

@@ -66,14 +66,12 @@ export default Component.extend({
     });
   },
 
-  actions: {
-    keyDown() {
-      once(this, '_check');
-      if (get(this, 'isNotSameEmail')) {
-        set(this, 'isChecking', true);
-      }
+  validateEmail: function() {
+    once(this, '_check');
+    if (get(this, 'isNotSameEmail')) {
+      set(this, 'isChecking', true);
     }
-  },
+  }.observes('email'),
 
   _check() {
     set(this, 'isChecking', true);

app/components/signup-password-input.js

@@ -19,7 +19,7 @@ export default Component.extend({
   suggestions: alias('strength.feedback.suggestions'),
 
   password: computed('user.password', function() {
-    return this.get('user.password') || '';
+    return get(this, 'user.password') || '';
   }),
 
   strength: computed('password', function() {
@@ -28,14 +28,14 @@ export default Component.extend({
   }),
 
   strengthPercentage: computed('isValid', 'passwordLength', 'strength', function() {
-    let isValid = this.get('isValid');
+    let isValid = get(this, 'isValid');
     let percentage = 0;
 
     if (isValid) {
-      let score = this.get('strength.score');
+      let score = get(this, 'strength.score');
       percentage = (score / 4) * 100;
     } else {
-      percentage = this.get('passwordLength');
+      percentage = get(this, 'passwordLength');
     }
 
     return percentage;

app/components/signup-username-input.js

@@ -184,6 +184,13 @@ export default Component.extend({
     return get(this, 'cachedUsername') === get(this, 'username');
   }),
 
+  validateUsername: function() {
+    once(this, '_check');
+    if (get(this, 'isNotSameUsername')) {
+      set(this, 'isChecking', true);
+    }
+  }.observes('username'),
+
   /**
     Checks if the username is valid and available. Caches the username so that
     it doesn't have to request more than once.
@@ -222,22 +229,6 @@ export default Component.extend({
     });
   },
 
-  actions: {
-
-    /**
-      Action that fires on key down. If the username is not the cached username,
-      it sets `isChecking` to true.
-
-      @method keyDown
-     */
-    keyDown() {
-      once(this, '_check');
-      if (get(this, 'isNotSameUsername')) {
-        set(this, 'isChecking', true);
-      }
-    }
-  },
-
   _check() {
     set(this, 'isChecking', true);
 

app/templates/components/signup-email-input.hbs

@@ -3,7 +3,7 @@
     <span class="input-label__text">Your email</span>
   </label>
 </div>
-{{input name="email" autocapitalize="off" type="text" value=user.email key-down="keyDown"}}
+{{input name="email" autocapitalize="off" type="text" value=user.email}}
 <div class="suggestions">
 {{#if canShowValidations}}
   {{#if isOkay}}

app/templates/components/signup-username-input.hbs

@@ -4,7 +4,7 @@
   </label>
 </div>
 {{#auto-focus}}
-  {{input name="username" autocapitalize="off" autofocus=true tabindex=0 type="text" value=user.username key-down="keyDown"}}
+  {{input name="username" autocapitalize="off" autofocus=true tabindex=0 type="text" value=user.username}}
 {{/auto-focus}}
 <div class="suggestions">
 {{#if canShowValidations}}

yarn.lock

@@ -3001,7 +3001,7 @@ ember-cli-normalize-entity-name@^1.0.0:
   dependencies:
     silent-error "^1.0.0"
 
-ember-cli-page-object@^1.13.0:
+[email protected]:
   version "1.13.0"
   resolved "https://registry.yarnpkg.com/ember-cli-page-object/-/ember-cli-page-object-1.13.0.tgz#9ac9342d9f90a363c429fbb14f3ad5c0be11827a"
   dependencies: