diff --git a/pkg/ccl/changefeedccl/alter_changefeed_test.go b/pkg/ccl/changefeedccl/alter_changefeed_test.go index 10b064995b54..000970181306 100644 --- a/pkg/ccl/changefeedccl/alter_changefeed_test.go +++ b/pkg/ccl/changefeedccl/alter_changefeed_test.go @@ -57,7 +57,7 @@ func TestAlterChangefeedAddTargetPrivileges(t *testing.T) { ctx := context.Background() s, db, _ := serverutils.StartServer(t, base.TestServerArgs{ - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), Knobs: base.TestingKnobs{ JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(), DistSQL: &execinfra.TestingKnobs{ diff --git a/pkg/ccl/changefeedccl/changefeed_test.go b/pkg/ccl/changefeedccl/changefeed_test.go index d5d0b55c96d6..08c2d7a92bfb 100644 --- a/pkg/ccl/changefeedccl/changefeed_test.go +++ b/pkg/ccl/changefeedccl/changefeed_test.go @@ -2621,7 +2621,7 @@ func TestChangefeedExternalIODisabled(t *testing.T) { } ctx := context.Background() s, db, _ := serverutils.StartServer(t, base.TestServerArgs{ - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), ExternalIODirConfig: base.ExternalIODirConfig{ DisableOutbound: true, }, @@ -4067,7 +4067,7 @@ func TestChangefeedCreateAuthorizationWithChangefeedPriv(t *testing.T) { ctx := context.Background() s, db, _ := serverutils.StartServer(t, base.TestServerArgs{ - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), Knobs: base.TestingKnobs{ JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(), DistSQL: &execinfra.TestingKnobs{ @@ -8384,9 +8384,7 @@ func TestChangefeedHandlesDrainingNodes(t *testing.T) { tc := serverutils.StartCluster(t, 4, base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - // Test uses SPLIT AT, which isn't currently supported for - // secondary tenants. Tracked with #76378. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), UseDatabase: "test", Knobs: knobs, ExternalIODir: sinkDir, @@ -8549,9 +8547,7 @@ func TestChangefeedHandlesRollingRestart(t *testing.T) { return perNode }(), ServerArgs: base.TestServerArgs{ - // Test uses SPLIT AT, which isn't currently supported for - // secondary tenants. Tracked with #76378. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), }, }) defer tc.Stopper().Stop(context.Background()) @@ -8707,9 +8703,7 @@ func TestChangefeedTimelyResolvedTimestampUpdatePostRollingRestart(t *testing.T) base.TestClusterArgs{ ServerArgsPerNode: perServerKnobs, ServerArgs: base.TestServerArgs{ - // Test uses SPLIT AT, which isn't currently supported for - // secondary tenants. Tracked with #76378. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), }, ReusableListenerReg: listenerReg, }) @@ -8802,9 +8796,7 @@ func TestChangefeedPropagatesTerminalError(t *testing.T) { ServerArgsPerNode: perServerKnobs, ReplicationMode: base.ReplicationManual, ServerArgs: base.TestServerArgs{ - // Test uses SPLIT AT, which isn't currently supported for - // secondary tenants. Tracked with #76378. - DefaultTestTenant: base.TODOTestTenantDisabled, + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), }, }) defer tc.Stopper().Stop(context.Background()) @@ -11309,7 +11301,7 @@ func TestChangefeedExecLocality(t *testing.T) { const nodes = 4 args := base.TestClusterArgs{ ServerArgs: base.TestServerArgs{ - DefaultTestTenant: base.TODOTestTenantDisabled, // need nodelocal and splits. + DefaultTestTenant: base.TestDoesNotWorkWithSecondaryTenantsButWeDontKnowWhyYet(142799), }, ServerArgsPerNode: map[int]base.TestServerArgs{}, } diff --git a/pkg/ccl/changefeedccl/parquet_test.go b/pkg/ccl/changefeedccl/parquet_test.go index a2a6afac7f7a..3329fec7a7d8 100644 --- a/pkg/ccl/changefeedccl/parquet_test.go +++ b/pkg/ccl/changefeedccl/parquet_test.go @@ -48,17 +48,16 @@ func TestParquetRows(t *testing.T) { skip.UnderStress(t) ctx := context.Background() - s, db, _ := serverutils.StartServer(t, base.TestServerArgs{ - // TODO(#98816): cdctest.GetHydratedTableDescriptor does not work with tenant dbs. - // Once it is fixed, this flag can be removed. - DefaultTestTenant: base.TODOTestTenantDisabled, - }) - defer s.Stopper().Stop(ctx) + srv, db, _ := serverutils.StartServer(t, base.TestServerArgs{}) + defer srv.Stopper().Stop(ctx) + s := srv.ApplicationLayer() + + sysDB := sqlutils.MakeSQLRunner(srv.SystemLayer().SQLConn(t)) + sysDB.Exec(t, "SET CLUSTER SETTING kv.rangefeed.enabled = true") maxRowGroupSize := int64(4) sqlDB := sqlutils.MakeSQLRunner(db) - sqlDB.Exec(t, "SET CLUSTER SETTING kv.rangefeed.enabled = true") newDecimal := func(s string) *tree.DDecimal { d, _, _ := apd.NewFromString(s) @@ -264,7 +263,7 @@ func TestParquetRows(t *testing.T) { } func makeRangefeedReaderAndDecoder( - t *testing.T, s serverutils.TestServerInterface, + t *testing.T, s serverutils.ApplicationLayerInterface, ) (func(t testing.TB) *kvpb.RangeFeedValue, func(), cdcevent.Decoder) { tableDesc := cdctest.GetHydratedTableDescriptor(t, s.ExecutorConfig(), "foo") popRow, cleanup := cdctest.MakeRangeFeedValueReader(t, s.ExecutorConfig(), tableDesc) diff --git a/pkg/ccl/changefeedccl/scheduled_changefeed_test.go b/pkg/ccl/changefeedccl/scheduled_changefeed_test.go index 77734ed7811c..6298f628ac76 100644 --- a/pkg/ccl/changefeedccl/scheduled_changefeed_test.go +++ b/pkg/ccl/changefeedccl/scheduled_changefeed_test.go @@ -9,7 +9,6 @@ import ( "context" gosql "database/sql" "fmt" - "net/url" "strconv" "strings" "testing" @@ -304,8 +303,7 @@ func TestCreateChangefeedScheduleChecksPermissionsDuringDryRun(t *testing.T) { defer log.Scope(t).Close(t) ctx := context.Background() - s, db, _ := serverutils.StartServer(t, base.TestServerArgs{ - DefaultTestTenant: base.TODOTestTenantDisabled, + srv, db, _ := serverutils.StartServer(t, base.TestServerArgs{ Knobs: base.TestingKnobs{ JobsTestingKnobs: jobs.NewTestingKnobsWithShortIntervals(), DistSQL: &execinfra.TestingKnobs{ @@ -320,25 +318,20 @@ func TestCreateChangefeedScheduleChecksPermissionsDuringDryRun(t *testing.T) { }, }, }) - defer s.Stopper().Stop(ctx) - rootDB := sqlutils.MakeSQLRunner(db) - rootDB.Exec(t, `SET CLUSTER SETTING kv.rangefeed.enabled = true`) + defer srv.Stopper().Stop(ctx) + s := srv.ApplicationLayer() + + sysDB := sqlutils.MakeSQLRunner(srv.SystemLayer().SQLConn(t)) + sysDB.Exec(t, "SET CLUSTER SETTING kv.rangefeed.enabled = true") + + sqlDB := sqlutils.MakeSQLRunner(db) enableEnterprise := utilccl.TestingDisableEnterprise() enableEnterprise() - rootDB.Exec(t, `CREATE TABLE table_a (i int)`) - rootDB.Exec(t, `CREATE USER testuser WITH PASSWORD 'test'`) + sqlDB.Exec(t, `CREATE TABLE table_a (i int)`) + sqlDB.Exec(t, `CREATE USER testuser WITH PASSWORD 'test'`) - pgURL := url.URL{ - Scheme: "postgres", - User: url.UserPassword("testuser", "test"), - Host: s.SQLAddr(), - } - db2, err := gosql.Open("postgres", pgURL.String()) - if err != nil { - t.Fatal(err) - } - defer db2.Close() + db2 := s.SQLConn(t, serverutils.UserPassword("testuser", "test")) userDB := sqlutils.MakeSQLRunner(db2) userDB.ExpectErr(t, `Failed to dry run create changefeed: user "testuser" requires the CHANGEFEED privilege on all target tables to be able to run an enterprise changefeed`,