kvnemesis: remove TestKVNemesisMultiNode_BufferedWritesNoPipelining

This configuration is no longer relevant since the TxnCoordSender
disables pipelining when buffered writes is in use.

Epic: none
Release note: None

Author: stevendanna

pkg/kv/kvnemesis/kvnemesis_test.go

@@ -430,7 +430,7 @@ func TestKVNemesisSingleNode_ReproposalChaos(t *testing.T) {
 }
 
 // TestKVNemesisMultiNode_BufferedWritesNoLockDurabilityUpgrades runs KVNemesis
-// with write buffering enabled and no lock durability ugprades. We leave splits
+// with write buffering enabled and no lock durability upgrades. We leave splits
 // to be metamorphic since those are all handled in-memory.
 func TestKVNemesisMultiNode_BufferedWritesNoLockDurabilityUpgrades(t *testing.T) {
 	defer leaktest.AfterTest(t)()
@@ -465,25 +465,6 @@ func TestKVNemesisMultiNode_BufferedWritesLockDurabilityUpgrades(t *testing.T) {
 	testKVNemesisImpl(t, cfg)
 }
 
-// TestKVNemesisMultiNode_BufferedWritesNoPipelining turns on buffered
-// writes and turns off write pipelining.
-func TestKVNemesisMultiNode_BufferedWritesNoPipelining(t *testing.T) {
-	defer leaktest.AfterTest(t)()
-	defer log.Scope(t).Close(t)
-
-	cfg := defaultTestConfiguration(3)
-	cfg.seedOverride = 0
-	cfg.bufferedWriteProb = 0.7
-	cfg.testSettings = func(ctx context.Context, st *cluster.Settings) {
-		kvcoord.BufferedWritesEnabled.Override(ctx, &st.SV, true)
-		kvcoord.PipelinedWritesEnabled.Override(ctx, &st.SV, false)
-		concurrency.UnreplicatedLockReliabilityLeaseTransfer.Override(ctx, &st.SV, true)
-		concurrency.UnreplicatedLockReliabilityMerge.Override(ctx, &st.SV, true)
-		concurrency.UnreplicatedLockReliabilitySplit.Override(ctx, &st.SV, true)
-	}
-	testKVNemesisImpl(t, cfg)
-}
-
 func TestKVNemesisMultiNode_Partition_Safety(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	defer log.Scope(t).Close(t)
@@ -829,25 +810,25 @@ func setAndVerifyZoneConfigs(
 ) {
 	// Set constraints on the system database; GeneratorDataTableID inherits from it.
 	sqlRunner.Exec(
-		t, `ALTER DATABASE system CONFIGURE ZONE USING 
-			num_replicas = 3, 
+		t, `ALTER DATABASE system CONFIGURE ZONE USING
+			num_replicas = 3,
 			num_voters = 3,
 			constraints = '{"+node=n1": 1, "+node=n2": 1}',
 			voter_constraints = '{"+node=n1": 1, "+node=n2": 1}'`,
 	)
 
 	// Ensure the liveness and meta ranges are also constrained appropriately.
 	sqlRunner.Exec(
-		t, `ALTER RANGE meta CONFIGURE ZONE USING 
-			num_replicas = 3, 
+		t, `ALTER RANGE meta CONFIGURE ZONE USING
+			num_replicas = 3,
 			num_voters = 3,
 			constraints = '{"+node=n1": 1, "+node=n2": 1}',
 			voter_constraints = '{"+node=n1": 1, "+node=n2": 1}'`,
 	)
 
 	sqlRunner.Exec(
-		t, `ALTER RANGE liveness CONFIGURE ZONE USING 
-			num_replicas = 3, 
+		t, `ALTER RANGE liveness CONFIGURE ZONE USING
+			num_replicas = 3,
 			num_voters = 3,
 			constraints = '{"+node=n1": 1, "+node=n2": 1}',
 			voter_constraints = '{"+node=n1": 1, "+node=n2": 1}'`,