Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

router.jsx 'replace' is defined but never used #137

Open
jayvdb opened this issue Jul 29, 2018 · 17 comments · May be fixed by #187
Open

router.jsx 'replace' is defined but never used #137

jayvdb opened this issue Jul 29, 2018 · 17 comments · May be fixed by #187
Labels
difficulty/newcomer

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 29, 2018

/home/travis/build/coala/gh-board/src/router.jsx
30:22 warning 'replace' is defined but never used no-unused-vars
@ANURADHAJHA99
Copy link

please assign this issue to me.

ANURADHAJHA99 referenced this issue in ANURADHAJHA99/gh-board Aug 1, 2018
@ANURADHAJHA99
ANURADHAJHA99
56d4d5f
@ANURADHAJHA99
Copy link

ANURADHAJHA99@56d4d5f

please review the commit

@li-boxuan
Copy link
Member

@ANURADHAJHA99 Please create a pull request.

@jayvdb
Copy link
Member Author

jayvdb commented Aug 4, 2018

And be sure to read https://coala.io/commit carefully before creating your first PR.

@jayvdb
Copy link
Member Author

jayvdb commented Aug 14, 2018

Ping @ANURADHAJHA99 , you will be unassigned unless you submit a pull request.

@ANURADHAJHA99
Copy link

Please give me 2 days time.My laptop is totally a wreck.i am getting a new one.

@ANURADHAJHA99
Copy link

I promise you I will submit a pull request with the stipulated time frame.

@ANURADHAJHA99
Copy link

I am answering through my phone..after setting the environment I will surely submit the pr.

@ANURADHAJHA99 ANURADHAJHA99 mentioned this issue Aug 22, 2018
Closed
@jayvdb
Copy link
Member Author

jayvdb commented Aug 23, 2018

@ANURADHAJHA99 , if you do not have access to command line git, you wont be able to complete this task at the moment, and you should ask to be un-assigned.

@ANURADHAJHA99
Copy link

I ask you to unassign me the following issue.Since I don't have the resources available right now.

@aditya81070
Copy link

I want to work on this issue. Please assign it to me.

@aditya81070
Copy link

@jayvdb please assign this issue to me.

@aditya81070
Copy link

@Makman2 please assign this issue to me.

@aditya81070 aditya81070 mentioned this issue Sep 22, 2018
Closed
aditya81070 pushed a commit to aditya81070/gh-board that referenced this issue Sep 22, 2018
Remove unnecessary parameter state and replace
0ff6f8d 
This Removes the unnecessary parameter `replace` and `state` from `onEnter` method.
This fixes the issue : coala#137
aditya81070 pushed a commit to aditya81070/gh-board that referenced this issue Sep 24, 2018
router.jsx: Remove unnecessary parameter state and onEnter
29de489 
This remove the warning `state is defined but never used`.

Close: coala#137
aditya81070 pushed a commit to aditya81070/gh-board that referenced this issue Sep 26, 2018
@aditya81070
router.jsx: Remove unnecessary arguments
44e8cb2 
The two arguments `state` and `onEnter` not required. In the route when `/dashboard` matches, it is directed to `/` using browserHistory.push().

Fixes : coala#137
aditya81070 pushed a commit to aditya81070/gh-board that referenced this issue Sep 29, 2018
@aditya81070
router.jsx: Remove unnecessary arguments
565f966 
The two arguments `state` and `onEnter` not required. In the route when `/dashboard` matches, it is directed to `/` using browserHistory.push().

Fixes coala#137
@tathagat2006
Copy link
Member

@jayvdb Please assign this issue to me. thanks :)

@li-boxuan
Copy link
Member

@tathagat2006 Please look for some other issue. This issue is assigned and there is an open PR.

@ankitgarg0006
Copy link

Hey. Is this issue still open. Please assign this to me.

GeniusLearner added a commit to GeniusLearner/gh-board that referenced this issue Sep 8, 2019
@GeniusLearner
router.jsx: Remove unused state & replace parameter
a4bf4e9 
The two arguments `state` and `replace` in `onEnter` are not required.
In the route when `/dashboard` matches, it is directed to `/` using
browserHistory.push().

Closes coala#137
@GeniusLearner GeniusLearner linked a pull request Sep 8, 2019 that will close this issue
Open
@Kartik-Khandelwal
Copy link

This issue is still open, i would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/newcomer
Milestone
No milestone
7 participants
@jayvdb @li-boxuan @aditya81070 @tathagat2006 @ANURADHAJHA99 @ankitgarg0006 @Kartik-Khandelwal