Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VisualBasic.yaml: Line length for grammar_file needs to be reduced #78

Closed
utkarsh2102 opened this issue Dec 3, 2018 · 4 comments
Closed

VisualBasic.yaml: Line length for grammar_file needs to be reduced #78

utkarsh2102 opened this issue Dec 3, 2018 · 4 comments
Labels
difficulty/newcomer

Comments

@utkarsh2102
Copy link
Member

utkarsh2102 commented Dec 3, 2018 •
edited
Loading

In VisualBasic.yaml:

coAST/data/Language/VisualBasic.yaml

Line 5 in 0110042

grammar_file: https://github.com/antlr/grammars-v4/blob/master/vb6/VisualBasic6.g4

The above line length (82) exceeds the maximum length, which is 79.
It'd be better if we shift this to a new line as is done in other files.

A good newcomer issue.
@naveentvelu
Copy link
Contributor

Can this issue assigned to me?

@naveentvelu naveentvelu mentioned this issue Dec 4, 2018
Closed
@utkarsh2102
Copy link
Member Author

@naveentata, only work on the issue when you are assigned. Please don't open any unnecessary PRs.

@naveentvelu
Copy link
Contributor

My apologies.
This won't happen again.

@li-boxuan
Copy link
Member

Solved by e13f222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/newcomer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

data/Language/VisualBasic.yaml : Reduce length of "grammar_file" naveentvelu/coAST
4 participants
@jayvdb @naveentvelu @li-boxuan @utkarsh2102