-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multiline badge text banner and 'Project' line in card #832
Comments
Well, I'll have to take a look at that, certainly. We generate all pages during the build time, so the plan is to run a Chrome in the background, calculate the text size and make a word wrap if necessary. |
Hey @AndreyKozlov1984 - any updates on this? |
Ok, focusing on this task now |
I support the |
Awesome - thank you @AndreyKozlov1984! That looks awesome! Can you do something similar on the cards themselves? |
With cards it looks complicated, my best approach would be to treat ' - ' as a line break. If we can agree that multiline is triggered by the presence of ' - ' in the text and that is replace with a new line, then yeah, I can get it working |
On your screenshot it is basically not enough space, even for a multiline |
- as line break works for me - thanks!
On Wed, Aug 17, 2022 at 7:38 AM Andrey Kozlov ***@***.***> wrote:
On your screenshot it is basically not enough space, even for a multiline
—
Reply to this email directly, view it on GitHub
<#832 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACIOIPSCFBXZPM5G7MMEA3VZTFMFANCNFSM53R6Z24A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Thank you,
John Mertic
Director of Program Management - Linux Foundation
ASWF, LF Energy, and Open Mainframe Project
***@***.***
+1 234-738-4571
Schedule time with me at https://meetings.hubspot.com/jmertic
|
Hmm - what other options do I have then? Could we have the badge two lines with line one the title and line two the text? |
Checking back in @AndreyKozlov1984 - seeing if you thought about my earlier comment and had any suggestions. |
Yes, multiline seems fine, I am a concerned with automatic detection of multiline, thus the label should somehow contain the information that we need to make it multiline. Maybe "!" or "..." or "-" on the end, @jmertic That one is possible for this tag, just I need to have a clear way to see that multiline is necessary, like "-" in the text. |
My proposal is that " - " in the value would mean we want a multiline. And, say, over 30 characters either in the name or in the value. Is this good ? |
Love it! Thanks @AndreyKozlov1984 |
Ok, I am pushing the change at this moment, the criteria is over 30 characters or "-" in the value, works well for LF-Energy I will ping you when this is deployed to production |
Thank you!
…On Thu, Sep 1, 2022 at 9:51 AM Andrey Kozlov ***@***.***> wrote:
Ok, I am pushing the change at this moment, the criteria is over 30
characters or "-" in the value, works well for LF-Energy
I will ping you when this is deployed to production
—
Reply to this email directly, view it on GitHub
<#832 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACIOIP4RM5XAA2W3V6ERFTV4CYE3ANCNFSM53R6Z24A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Awesome! I am seeing some alignment issues in my deploy preview below... https://deploy-preview-565--lfenergy.netlify.app/?selected=carbon-data-specification-consortium-cdsc Can you take a quick peek? |
Done, I have updated the landscapeapp. |
Awesome - thank you @AndreyKozlov1984 ! |
First request, let the next under the badges be multiline; see image below for where I'm talking about. Ideally that text would change to 'Technical Project\nIncubation'
Second, notice the text for 'LF Energy Technical Project' cuts off as it's too long. Would be great for it to not cut off or wrap perhaps.
The text was updated successfully, but these errors were encountered: