Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh China Video Block plugin #660

Open
cjyabraham opened this issue Feb 22, 2023 · 2 comments
Open

Refresh China Video Block plugin #660

cjyabraham opened this issue Feb 22, 2023 · 2 comments
Assignees

Comments

@cjyabraham
Copy link
Collaborator

To celebrate its 10,000 download, test and refresh the China Video Block plugin to make sure it's working and useful to both us and other people.

@cjyabraham
Copy link
Collaborator Author

FYI, I have removed this plugin from our codebases since it wasn't being used and we didn't want to continue our subscription to ipinfo.

If we decide to work on this more, we could use the new way of testing for geolocation that doesn't require ipinfo. Ipinfo was proving not very effective as it is since privacy blocking plugins were blocking it.

@thetwopct
Copy link
Collaborator

@cjyabraham I've done some work on this:

  • modernised the plugin - dropped Create Guten Block and instead used the wp-scripts package, make more use of block.json
  • switched from SCSS to plain CSS
  • Added some block features like alignment, custom classnames and anchor points
  • added some wordpress.org assets (icons and banners) plus a blueprint (needs some testing)
  • Added wp-env to quickly spin up a dev site, added sniff checking/fixing via composer
  • Added a GitHub workflow to compile a zip for testing on each branch / PR

I'll leave it to you to release on wordpress.org - if you need to automate the releasing I have a GitHub workflow that can deploy to the org repo.

@thetwopct thetwopct assigned cjyabraham and unassigned thetwopct Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Later
Development

No branches or pull requests

2 participants