-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase .clomonitor.yml configuration #140
Comments
Hi @jeefy
A user brought this up recently and we mentioned we were considering making it configurable via However, we're not really sure if this the right thing to do, specially for documentation related checks. The reason is that IMHO it'd be great if we could encourage projects to make this information a bit easier to discover by final users. Having this information in So in addition to support some standard well known locations, some checks are now able to detect certain headers in README files (checks like The |
Check if the `README` file contains a *contributing* header in addition to checking the presence of the `CONTRIBUTING.md` file. Related to #140 Signed-off-by: Sergio Castaño Arteaga <[email protected]>
Check if the `README` file contains a *contributing* header in addition to checking the presence of the `CONTRIBUTING.md` file. Related to #140 Signed-off-by: Sergio Castaño Arteaga <[email protected]>
Done, Akri's contributing check is now passing. |
Could we perhaps pass the I think that'll give enough flexibility and control to close this out. I'm happy to close this issue and create a new one for this if that's easier. :) |
Sure, this is not a problem. However, I thought this was a requirement as mentioned in the website guidelines document:
@caniszczyk requested this one in cncf/toc#73, maybe he can confirm 🙂 |
We have some edge cases (like Akri) where they don't have a full blown website. In this case they're using GitBook for their website (https://docs.akri.sh/). That doesn't have control over Headers or Footers, so we should support checking for the Trademark disclaimer in an alternative place. Happy to wait for @caniszczyk to weigh in. |
If a project doesn't have a website then that's a problem, we should build
them one :)
…On Tue, Mar 8, 2022 at 9:20 AM Jeffrey Sica ***@***.***> wrote:
Sure, this is not a problem. However, I thought this was a requirement as
mentioned in the website guidelines document
<https://github.com/cncf/foundation/blob/main/website-guidelines.md>:
We have some edge cases (like Akri) where they don't have a full blown
website. In this case they're using GitBook for their website (
https://docs.akri.sh/). That doesn't have control over Headers or
Footers, so we should support checking for the Trademark disclaimer in an
alternative place.
Happy to wait for @caniszczyk <https://github.com/caniszczyk> to weigh in.
—
Reply to this email directly, view it on GitHub
<#140 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAPSILMA5LBZJWKTYSDRBTU65V4VANCNFSM5QALC5VA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Cheers,
Chris Aniszczyk
https://aniszczyk.org
|
We are not checking for the trademark disclaimer to be in any specific location, so as long as the regex below matches the content returned when fetching the website document, the check should pass. In the Akri case, it could be added to the
|
That's super helpful! Thanks! |
I think we can close this one now, please feel free to reopen if needed. |
Feel free to close this and break it up into separate issues, but I want to capture all the ideas under one since they all involve .clomonitor.yml :)
For example, https://github.com/project-akri/akri has the header
Community, Contributing, and Support
, which also links to their Contributing page https://docs.akri.sh/community/contributing.Being able to specify in the YAML something like
contributing_url: https://docs.akri.sh/community/contributing
and pass the check would be great.clomonitor.yml
. For example(s), Akri or Envoy explicitly state on their docs that they're part of the CNCF. This is technically an accepted path (See [SANDBOX PROJECT ONBOARDING] Akri sandbox#229)The text was updated successfully, but these errors were encountered: