Skip to content

Conversation

dajmcdon
Copy link
Contributor

@dajmcdon dajmcdon commented Apr 8, 2025

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • Styling and documentation checks. Make a PR comment with:
    • /document to check the package documentation and fix any issues.
    • /style to check the style and fix any issues.
    • /preview-docs to preview the docs.
    • See Actions GitHub tab to track progress of these commands.
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dajmcdon dajmcdon requested a review from brookslogan April 8, 2025 17:46
@dajmcdon
Copy link
Contributor Author

dajmcdon commented Apr 8, 2025

/preview-docs

Copy link

github-actions bot commented Apr 8, 2025

{epipredict} site has working GitHub and source links (to appropriate main/dev
branches) while excluding the repo: setting from its _pkgdown.yml, so see if it
works here as well.
@brookslogan
Copy link
Contributor

/preview-docs

@brookslogan
Copy link
Contributor

brookslogan commented Apr 8, 2025

/preview-docs

previous attempt was skipped for some reason? [That was a different PR. Maybe the one on this did run; not sure what happened.] [I think it updated the site at the link above; source links appear to be working!]

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think these changes make the site work.

@brookslogan brookslogan merged commit 121cc88 into dev Apr 8, 2025
3 checks passed
@brookslogan brookslogan deleted the hotfix-linking branch April 8, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants