From 3785fac49cf265a49a769fbe1af2fe5eb05292c1 Mon Sep 17 00:00:00 2001 From: Shahzad Malik Muzaffar Date: Mon, 27 Oct 2025 12:01:58 +0100 Subject: [PATCH] [SIMULATION] To virtual method inside a final class; make classes non-final --- DataFormats/GeometrySurface/interface/SimpleConeBounds.h | 2 +- DataFormats/GeometrySurface/interface/SimpleCylinderBounds.h | 2 +- DataFormats/GeometrySurface/interface/SimpleDiskBounds.h | 2 +- SimCalorimetry/HcalSimAlgos/interface/HcalSiPMHitResponse.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DataFormats/GeometrySurface/interface/SimpleConeBounds.h b/DataFormats/GeometrySurface/interface/SimpleConeBounds.h index 6ac57ff7d3c7c..5668d4b08dcf6 100644 --- a/DataFormats/GeometrySurface/interface/SimpleConeBounds.h +++ b/DataFormats/GeometrySurface/interface/SimpleConeBounds.h @@ -20,7 +20,7 @@ #include #include -class SimpleConeBounds final : public Bounds { +class SimpleConeBounds : public Bounds { public: /// Construct from inner/outer radius on the two Z faces SimpleConeBounds(float zmin, float rmin_zmin, float rmax_zmin, float zmax, float rmin_zmax, float rmax_zmax) diff --git a/DataFormats/GeometrySurface/interface/SimpleCylinderBounds.h b/DataFormats/GeometrySurface/interface/SimpleCylinderBounds.h index dea17f6fe200a..fc719a3cb0878 100644 --- a/DataFormats/GeometrySurface/interface/SimpleCylinderBounds.h +++ b/DataFormats/GeometrySurface/interface/SimpleCylinderBounds.h @@ -16,7 +16,7 @@ #include #include -class SimpleCylinderBounds final : public Bounds { +class SimpleCylinderBounds : public Bounds { public: SimpleCylinderBounds(float rmin, float rmax, float zmin, float zmax); diff --git a/DataFormats/GeometrySurface/interface/SimpleDiskBounds.h b/DataFormats/GeometrySurface/interface/SimpleDiskBounds.h index 87b770f7ef939..9a87881cf1f7e 100644 --- a/DataFormats/GeometrySurface/interface/SimpleDiskBounds.h +++ b/DataFormats/GeometrySurface/interface/SimpleDiskBounds.h @@ -8,7 +8,7 @@ * Plane bounds that define a disk with a concentric hole in the middle. */ -class SimpleDiskBounds final : public Bounds { +class SimpleDiskBounds : public Bounds { public: /// Construct the bounds from min and max R and Z in LOCAL coordinates. SimpleDiskBounds(float rmin, float rmax, float zmin, float zmax); diff --git a/SimCalorimetry/HcalSimAlgos/interface/HcalSiPMHitResponse.h b/SimCalorimetry/HcalSimAlgos/interface/HcalSiPMHitResponse.h index 16ab2115281ba..543ce6ba583a0 100644 --- a/SimCalorimetry/HcalSimAlgos/interface/HcalSiPMHitResponse.h +++ b/SimCalorimetry/HcalSimAlgos/interface/HcalSiPMHitResponse.h @@ -19,7 +19,7 @@ class PCaloHitCompareTimes { bool operator()(const PCaloHit* a, const PCaloHit* b) const { return a->time() < b->time(); } }; -class HcalSiPMHitResponse final : public CaloHitResponse { +class HcalSiPMHitResponse : public CaloHitResponse { public: HcalSiPMHitResponse(const CaloVSimParameterMap* parameterMap, const CaloShapes* shapes,