[15_0_X] fix:Duplicate DeepCSV path removal, onnx model update by uttiyasarkar · Pull Request #48853 · cms-sw/cmssw

uttiyasarkar · 2025-09-05T16:51:29Z

PR description:

This is a backport of PR#48256 which includes the fixed DeepJet model in Phase-2 menu with corrected softmax layer and duplicate DeepCSV paths being removed

cmsbuild · 2025-09-05T16:51:57Z

A new Pull Request was created by @uttiyasarkar for CMSSW_15_0_X.

It involves the following packages:

HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Backported from fix:Duplicate DeepCSV path removal, onnx model update #48256

cmsbuild · 2025-09-05T16:51:57Z

cms-bot internal usage

mmusich · 2025-09-05T16:54:43Z

@uttiyasarkar this needs to be tested with a backport of cms-sw/cmsdist#9918 to the IB/CMSSW_15_0_X/master branch of cmsdist. Please provide one.

mmusich · 2025-09-05T16:55:10Z

backport of #48256

mmusich · 2025-09-06T15:20:03Z

test parameters:

pull_request = Update tag for RecoBTag-Combined to V01-31-00 cmsdist#10060

mmusich · 2025-09-06T15:20:11Z

@cmsbuild, please test

cmsbuild · 2025-09-06T17:43:57Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f7f9/47994/summary.html
COMMIT: e2c313a
CMSSW: CMSSW_15_0_X_2025-09-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48853/47994/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 17 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 38 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4020850
DQMHistoTests: Total failures: 33
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4020797
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: found differences in 4 / 48 workflows

mmusich · 2025-09-08T07:20:32Z

HLTrigger/Configuration/python/HLT_75e33_cff.py

    fragment.HLT_PFPuppiMETTypeOne140_PFPuppiMHT140,

-    fragment.L1T_PFHT400PT30_QuadPFPuppiJet_70_55_40_40_2p4,
-    fragment.L1T_DoublePFPuppiJets112_2p4_DEta1p6,


the deletion of these two lines are not included in the master PR version #48256.
Please clarify the reason of the deletion.

I am wondering why these two lines are deleted (probably accidentally removed while resolving the conflict, sorry about this). I can add them back in a commit

can you please put them back where they were (L362-363) and not later (L367-368)?
Also please squash the commits.

Everything should ideally be resolved

cmsbuild · 2025-09-08T10:46:59Z

Pull request #48853 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

cmsbuild · 2025-09-08T12:38:36Z

Pull request #48853 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

fix:Duplicate DeepCSV path removal, onnx model update bug:readded deleted L1 fragments Fix: onnx update and deepcsv duplicate path removal

cmsbuild · 2025-09-08T12:41:08Z

Pull request #48853 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

mmusich · 2025-09-08T12:58:06Z

@cmsbuild, please test

mmusich · 2025-09-08T12:58:13Z

type bug-fix

cmsbuild · 2025-09-08T15:20:18Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34f7f9/48011/summary.html
COMMIT: 3a80e7f
CMSSW: CMSSW_15_0_X_2025-09-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48853/48011/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 40 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 4020850
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4020827
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 218 log files, 189 edm output root files, 50 DQM output files
TriggerResults: found differences in 4 / 48 workflows

mmusich · 2025-09-08T15:26:31Z

+hlt

for uttiyasarkar@3a80e7f
bug-fix: verbatim backport of fix:Duplicate DeepCSV path removal, onnx model update #48256 to CMSSW_15_0_X

cmsbuild · 2025-09-08T15:26:58Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_15_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_15_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmsdist#10060

cmsbuild · 2025-09-08T19:48:38Z

REMINDER @mandrenguyen, @ftenchini, @sextonkennedy: This PR was tested with cms-sw/cmsdist#10060, please check if they should be merged together

mandrenguyen · 2025-09-09T15:36:59Z

+1

cmsbuild added this to the CMSSW_15_0_X milestone Sep 5, 2025

cmsbuild added hlt-pending pending-signatures tests-pending orp-pending labels Sep 5, 2025

cmsbuild added the backport-ok label Sep 5, 2025

uttiyasarkar mentioned this pull request Sep 5, 2025

Update tag for RecoBTag-Combined to V01-31-00 cms-sw/cmsdist#10060

Merged

cmsbuild added tests-started requires-external and removed tests-pending labels Sep 6, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 6, 2025

mmusich reviewed Sep 8, 2025

View reviewed changes

cmsbuild added tests-pending and removed tests-approved labels Sep 8, 2025

fix:removal from the scheduler

3a80e7f

fix:Duplicate DeepCSV path removal, onnx model update bug:readded deleted L1 fragments Fix: onnx update and deepcsv duplicate path removal

uttiyasarkar force-pushed the backport-PR48256-to-CMSSW_15_0_X branch from 62f6ba9 to 3a80e7f Compare September 8, 2025 12:40

cmsbuild removed the tests-pending label Sep 8, 2025

cmsbuild added tests-started bug-fix labels Sep 8, 2025

cmsbuild added tests-approved and removed tests-started labels Sep 8, 2025

cmsbuild added hlt-approved fully-signed and removed hlt-pending pending-signatures labels Sep 8, 2025

mandrenguyen changed the title ~~Backport PR#48256 to CMSSW_15_0_X~~ [15_0_X] fix:Duplicate DeepCSV path removal, onnx model update Sep 8, 2025

cmsbuild added orp-approved and removed orp-pending labels Sep 9, 2025

cmsbuild merged commit cd7ca8a into cms-sw:CMSSW_15_0_X Sep 9, 2025
9 checks passed

Conversation

uttiyasarkar commented Sep 5, 2025

PR description:

Uh oh!

cmsbuild commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mmusich commented Sep 5, 2025

Uh oh!

mmusich commented Sep 5, 2025

Uh oh!

mmusich commented Sep 6, 2025

Uh oh!

mmusich commented Sep 6, 2025

Uh oh!

cmsbuild commented Sep 6, 2025

Comparison Summary

Uh oh!

mmusich Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

uttiyasarkar Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmusich Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

uttiyasarkar Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

mmusich commented Sep 8, 2025

Uh oh!

mmusich commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Comparison Summary

Uh oh!

mmusich commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

cmsbuild commented Sep 8, 2025

Uh oh!

mandrenguyen commented Sep 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Sep 5, 2025 •

edited

Loading

cmsbuild commented Sep 5, 2025 •

edited

Loading

uttiyasarkar Sep 8, 2025 •

edited

Loading