Skip to content

Add IOTrace debug-level messages to edm::RootTree #48220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Jun 5, 2025
Merged

Add IOTrace debug-level messages to edm::RootTree #48220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions IOPool/Input/src/RootTree.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
#include "RootTree.h"
#include "RootDelayedReader.h"
#include "RootPromptReadDelayedReader.h"
#include "DataFormats/Provenance/interface/BranchType.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "FWCore/Utilities/interface/EDMException.h"
#include "FWCore/Utilities/interface/Exception.h"
#include "DataFormats/Provenance/interface/BranchType.h"
#include "IOPool/Common/interface/getWrapperBasePtr.h"

#include "InputFile.h"
#include "RootTree.h"
#include "RootDelayedReader.h"
#include "RootPromptReadDelayedReader.h"

#include "TTree.h"
#include "TTreeCache.h"
#include "TLeaf.h"
Expand Down Expand Up @@ -437,6 +440,8 @@ namespace edm {
}

inline void RootTree::getEntryUsingCache(TBranch* branch, EntryNumber entryNumber, TTreeCache* cache) const {
LogTrace("IOTrace").format(
"RootTree::getEntryUsingCache() begin for branch {} entry {}", branch->GetName(), entryNumber);
try {
auto guard = filePtr_->setCacheReadTemporarily(cache, tree_);
branch->GetEntry(entryNumber);
Expand All @@ -457,6 +462,8 @@ namespace edm {
t.addContext(std::string("Reading branch ") + branch->GetName());
throw t;
}
LogTrace("IOTrace").format(
"RootTree::getEntryUsingCache() end for branch {} entry {}", branch->GetName(), entryNumber);
}

bool RootTree::skipEntries(unsigned int& offset) {
Expand Down
2 changes: 0 additions & 2 deletions Utilities/StorageFactory/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ There is an `edmStorageTracer.py` script for doing some analyses of the traces.
The `StorageTracerProxy` also provides a way to correlate the trace entries with the rest of the framework via [MessageLogger](../../FWCore/MessageService/Readme.md) messages. These messages are issued with the DEBUG severity and `IOTrace` category. There are additional, higher-level messages as part of the `PoolSource`. To see these messages, compile the `Utilities/Storage` and `IOPool/Input` packages with `USER_CXXFLAGS="-DEDM_ML_DEBUG", and customize the MessageLogger configuration along
```py
process.MessageLogger.cerr.threshold = "DEBUG"
process.MessageLogger.debugModules = ["*"]
process.MessageLogger.IOTrace = dict()
```

#### `StorageAddLatencyProxy`
Expand Down