Skip to content

MTD Geometry: update DDD filtering for better memory performance #46531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Nov 8, 2024
Merged

MTD Geometry: update DDD filtering for better memory performance #46531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 28 additions & 16 deletions Geometry/MTDNumberingBuilder/plugins/DDCmsMTDConstruction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,38 +22,50 @@ using angle_units::operators::convertRadToDeg;

class DDNameFilter : public DDFilter {
public:
void addNS(const std::string& addNS) { allowedNS_.emplace_back(addNS); }
void add(const std::string& add) { allowed_.emplace_back(add); }
void veto(const std::string& veto) { veto_.emplace_back(veto); }

bool accept(const DDExpandedView& ev) const final {
std::string currentName(ev.logicalPart().name().fullname());
for (const auto& test : veto_) {
if (currentName.find(test) != std::string::npos)
return false;
if (allowedNS_.size() == 0 && allowed_.size() == 0 && veto_.size() == 0) {
return true;
}
for (const auto& test : allowed_) {
if (currentName.find(test) != std::string::npos)
return true;
bool out(false);
std::string_view currentNSName(ev.logicalPart().name().ns());
for (const auto& test : allowedNS_) {
if (currentNSName.find(test) != std::string::npos) {
out = true;
if (allowed_.size() > 0 || veto_.size() > 0) {
std::string_view currentName(ev.logicalPart().name().name());
for (const auto& test : veto_) {
if (currentName.find(test) != std::string::npos) {
return false;
}
}
for (const auto& test : allowed_) {
if (currentName.find(test) != std::string::npos) {
return true;
}
}
}
break;
}
}
return false;
return out;
}

private:
std::vector<std::string> allowedNS_;
std::vector<std::string> allowed_;
std::vector<std::string> veto_;
};

std::unique_ptr<GeometricTimingDet> DDCmsMTDConstruction::construct(const DDCompactView& cpv) {
std::string attribute{"CMSCutsRegion"};
DDNameFilter filter;
filter.add("mtd:");
filter.add("btl:");
filter.add("etl:");

std::vector<std::string> volnames = {"FSide", "SupportPlate"};
for (auto const& theVol : volnames) {
filter.veto(theVol);
}
filter.addNS("mtd");
filter.addNS("btl");
filter.addNS("etl");

DDFilteredView fv(cpv, filter);

Expand Down