Skip to content

Minuit2::FCNBase: fix for root 6.32#46006

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
smuzaffar:FCNBase-root632
Sep 16, 2024
Merged

Minuit2::FCNBase: fix for root 6.32#46006
cmsbuild merged 1 commit intocms-sw:masterfrom
smuzaffar:FCNBase-root632

Conversation

@smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Sep 16, 2024 •
edited
Loading

This fixes a typo in #45965 . The root version which has the Minuit2::FCNBase interface change is ROOT 6.33 while #45965 has mistakenly applied the change for ROOT 6.32. This should fix the ROOT 6.32 build errors https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_2_ROOT632_X_2024-09-13-2300/RecoVertex/BeamSpotProducer

In file included from src/RecoVertex/BeamSpotProducer/src/FcnBeamSpotFitPV.cc:1:
  src/RecoVertex/BeamSpotProducer/interface/FcnBeamSpotFitPV.h:35:10: error: 'double FcnBeamSpotFitPV::operator()(std::span<const double>) const' marked 'override', but does not override
    35 |   double operator()(std::span<const double>) const override;
      |          ^~~~~~~~
  src/RecoVertex/BeamSpotProducer/src/BSpdfsFcn.cc:24:8: error: no declaration matches 'double BSpdfsFcn::PDFGauss_d(double, double, double, double, std::span<const double>) const'
    24 | double BSpdfsFcn::PDFGauss_d(double z, double d, double sigmad, double phi, std::span<const double> parms) const {
      |        ^~~~~~~~~
In file included from src/RecoVertex/BeamSpotProducer/src/BSpdfsFcn.cc:13:
src/RecoVertex/BeamSpotProducer/interface/BSpdfsFcn.h:47:10: note: candidate is: 'double BSpdfsFcn::PDFGauss_d(double, double, double, double, const std::vector<double>&) const'
   47 |   double PDFGauss_d(double z, double d, double sigmad, double phi, const std::vector<double>& parms) const;
      |          ^~~~~~~~~~
src/RecoVertex/BeamSpotProducer/interface/BSpdfsFcn.h:26:7: note: 'class BSpdfsFcn' defined here
   26 | class BSpdfsFcn : public ROOT::Minuit2::FCNBase {
      |       ^~~~~~~~~
  src/RecoVertex/BeamSpotProducer/src/BSpdfsFcn.cc:46:8: error: no declaration matches 'double BSpdfsFcn::PDFGauss_d_resolution(double, double, double, double, std::span<const double>) const'
    46 | double BSpdfsFcn::PDFGauss_d_resolution(double z, double d, double phi, double pt, std::span<const double> parms) const {
      |        ^~~~~~~~~
src/RecoVertex/BeamSpotProducer/interface/BSpdfsFcn.h:48:10: note: candidate is: 'double BSpdfsFcn::PDFGauss_d_resolution(double, double, double, double, const std::vector<double>&) const'
   48 |   double PDFGauss_d_resolution(double z, double d, double phi, double pt, const std::vector<double>& parms) const;
      |          ^~~~~~~~~~~~~~~~~~~~~
src/RecoVertex/BeamSpotProducer/interface/BSpdfsFcn.h:26:7: note: 'class BSpdfsFcn' defined here
   26 | class BSpdfsFcn : public ROOT::Minuit2::FCNBase {
      |       ^~~~~~~~~

@cmsbuild cmsbuild added this to the CMSSW_14_2_X milestone Sep 16, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2024 •
edited
Loading

cms-bot internal usage

@smuzaffar smuzaffar mentioned this pull request Sep 16, 2024
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46006/41801

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • RecoVertex/BeamSpotProducer (reconstruction, alca)

@cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @VinInn, @VourMa, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Sep 16, 2024

please test for CMSSW_14_2_ROOT632_X

@iarspider
Copy link
Contributor

iarspider commented Sep 16, 2024

thanks!

@smuzaffar
Copy link
Contributor Author

smuzaffar commented Sep 16, 2024

please test

lets run tests for production IB/branch

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37a360/41524/summary.html
COMMIT: 20de7df
CMSSW: CMSSW_14_2_ROOT632_X_2024-09-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46006/41524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 16, 2024

+1

@perrotta
Copy link
Contributor

perrotta commented Sep 16, 2024

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 16, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-37a360/41526/summary.html
COMMIT: 20de7df
CMSSW: CMSSW_14_2_X_2024-09-15-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46006/41526/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3437830
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3437807
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 197 log files, 168 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar smuzaffar mentioned this pull request Sep 16, 2024
Merged
@antoniovilela
Copy link
Contributor

antoniovilela commented Sep 16, 2024

+1

@cmsbuild cmsbuild merged commit 5587561 into cms-sw:master Sep 16, 2024
This was referenced Sep 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

alca-approved code-checks-approved fully-signed orp-approved reconstruction-approved tests-approved tracking

Projects

None yet

Milestone

CMSSW_14_2_X

Development

Successfully merging this pull request may close these issues.

6 participants

@smuzaffar @cmsbuild @iarspider @jfernan2 @perrotta @antoniovilela