From 187e20ad66f468b124c8d321b48f482a7ce0bff6 Mon Sep 17 00:00:00 2001 From: aandvalenzuela Date: Mon, 27 Nov 2023 19:42:19 +0100 Subject: [PATCH 1/2] [ALCA-DB] Fix copy-constructor warnings reported in DEVEL IBs --- CondFormats/PhysicsToolsObjects/interface/MVAComputer.h | 6 ------ CondFormats/SiStripObjects/interface/SiStripBadStrip.h | 4 ---- CondFormats/SiStripObjects/interface/SiStripNoises.h | 1 - CondFormats/SiStripObjects/src/SiStripNoises.cc | 7 ------- 4 files changed, 18 deletions(-) diff --git a/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h b/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h index 394d09d39a4ff..99117fa5f1477 100644 --- a/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h +++ b/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h @@ -28,12 +28,6 @@ namespace PhysicsTools { class BitSet { public: - // help that poor ROOT to copy bitsets... (workaround) - BitSet &operator=(const BitSet &other) { - store = other.store; - bitsInLast = other.bitsInLast; - return *this; - } std::vector store; unsigned int bitsInLast; diff --git a/CondFormats/SiStripObjects/interface/SiStripBadStrip.h b/CondFormats/SiStripObjects/interface/SiStripBadStrip.h index 88e905cfdaf5b..a2b3ad36e629d 100644 --- a/CondFormats/SiStripObjects/interface/SiStripBadStrip.h +++ b/CondFormats/SiStripObjects/interface/SiStripBadStrip.h @@ -56,10 +56,6 @@ class SiStripBadStrip { typedef Container InputVector; SiStripBadStrip(){}; - SiStripBadStrip(const SiStripBadStrip& orig) { - v_badstrips = orig.v_badstrips; - indexes = orig.indexes; - } virtual ~SiStripBadStrip(){}; bool put(const uint32_t& detID, const InputVector& vect) { return put(detID, Range(vect.begin(), vect.end())); } diff --git a/CondFormats/SiStripObjects/interface/SiStripNoises.h b/CondFormats/SiStripObjects/interface/SiStripNoises.h index 6bbd071ef23fa..d936ad51b38cb 100644 --- a/CondFormats/SiStripObjects/interface/SiStripNoises.h +++ b/CondFormats/SiStripObjects/interface/SiStripNoises.h @@ -49,7 +49,6 @@ class SiStripNoises { typedef Registry::const_iterator RegistryIterator; typedef std::vector InputVector; - SiStripNoises(const SiStripNoises&); SiStripNoises() {} ~SiStripNoises() {} diff --git a/CondFormats/SiStripObjects/src/SiStripNoises.cc b/CondFormats/SiStripObjects/src/SiStripNoises.cc index 20373bf940bf0..05bf49fecb08c 100644 --- a/CondFormats/SiStripObjects/src/SiStripNoises.cc +++ b/CondFormats/SiStripObjects/src/SiStripNoises.cc @@ -6,13 +6,6 @@ #include #include "CondFormats/SiStripObjects/interface/SiStripDetSummary.h" -SiStripNoises::SiStripNoises(const SiStripNoises& input) { - v_noises.clear(); - indexes.clear(); - v_noises.insert(v_noises.end(), input.v_noises.begin(), input.v_noises.end()); - indexes.insert(indexes.end(), input.indexes.begin(), input.indexes.end()); -} - bool SiStripNoises::put(const uint32_t& DetId, const InputVector& input) { std::vector Vo_CHAR; encode(input, Vo_CHAR); From 922429aba3d26bffaf003ba0b827171b28c2c936 Mon Sep 17 00:00:00 2001 From: aandvalenzuela Date: Mon, 27 Nov 2023 19:42:33 +0100 Subject: [PATCH 2/2] apply code format --- CondFormats/PhysicsToolsObjects/interface/MVAComputer.h | 1 - 1 file changed, 1 deletion(-) diff --git a/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h b/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h index 99117fa5f1477..2189275bbc063 100644 --- a/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h +++ b/CondFormats/PhysicsToolsObjects/interface/MVAComputer.h @@ -28,7 +28,6 @@ namespace PhysicsTools { class BitSet { public: - std::vector store; unsigned int bitsInLast;