Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
5e0a9dd
update the TnP code for GEM muon efficiency measurement
qyguo Mar 12, 2023
e428d1b
GEM TnP efficiency removing the ring
qyguo Mar 14, 2023
98b1c27
TnP Efficiency for GEM removing unused variable
qyguo Mar 14, 2023
4ab1a92
Try to introduce the gurad rings for both full and partial wafers of …
Mar 14, 2023
343912e
Code check
Mar 14, 2023
577d690
Update from Pruthvi
Mar 14, 2023
8972bf5
Code check
Mar 14, 2023
c4c7c68
update the TnP efficiency measurement of GEM for eta
qyguo Mar 14, 2023
7a6d442
updated for new displaced photon + HT path for 2023, cleaned up monit…
jalimena Mar 15, 2023
2a0d4b1
update the format
qyguo Mar 16, 2023
4bbb818
reverting back to run3_data_relval for making rereco GT default in re…
sunilUIET Mar 17, 2023
832dba0
added EXOLLPJetHCAL skim (initial version)
Mar 17, 2023
16c2600
clean up comments
Mar 17, 2023
6250e50
Migrate consumesMany to GetterOfProducts
wddgit Mar 17, 2023
3602899
bug fix
Mar 17, 2023
a5577b0
HI 2023 relval wfs + realistic 2022 vtx smearing
mandrenguyen Mar 18, 2023
48b21f2
fix dataset path
mandrenguyen Mar 18, 2023
22933fd
Replace M() with M2() in HLTProducers
perrotta Mar 19, 2023
396f34b
Replace DeltaR with DeltaR2 in RecoTauTag/HLTProducers
perrotta Mar 19, 2023
2ccf189
Consider possible negative values of the parameter as a way to skip c…
perrotta Mar 20, 2023
4c8c60a
issue fixed by comments and suggestions
qyguo Mar 20, 2023
7a82cb8
Add CMSHepEmTrackingManager
hahnjo Mar 20, 2023
376cce0
HLT menu development for 13_0_X (branch: 13_1_X)
missirol Mar 20, 2023
c51b695
fixed hcal rechit collection
Mar 20, 2023
37bf4f6
updated HLT path string
Mar 20, 2023
43e2ecb
Merge pull request #41061 from jalimena/dispPhotonHltDqm
cmsbuild Mar 21, 2023
2dbf550
Merge pull request #41110 from hahnjo/cmshepemtrackingmanager
cmsbuild Mar 21, 2023
c355de4
Merge pull request #41109 from wddgit/hcalDigiDumpUseGetter
cmsbuild Mar 21, 2023
96d7207
update GlobalTag used in phase-2 Alignment/OfflineValidation unit tests
mmusich Mar 21, 2023
b8b0a9e
Apply code review comments
perrotta Mar 21, 2023
89d0809
update GlobalTag used in phase-2 CondTools/SiPixel unit tests
mmusich Mar 21, 2023
763e112
update GlobalTag used in phase-2 RecoTracker/MkFit unit tests
mmusich Mar 21, 2023
9ba4905
do not apply alignment in listIds_PhaseII unit test
mmusich Mar 21, 2023
9a02541
Merge pull request #41100 from perrotta/reduceSqrtInHltProducers
cmsbuild Mar 21, 2023
9947590
Include TkAl Rcds back in Phase2 GT
saumyaphor4252 Mar 21, 2023
998ad83
Remove reinterpret_cast from L1TGlobalTrigger
aloeliger Mar 21, 2023
4c4bee9
Merge pull request #41113 from cms-tsg-storm/HLTdevelopment130X_for131X
cmsbuild Mar 21, 2023
3ea00a5
remove the const_cast from SiStripFedCablingFakeESSource
mmusich Mar 21, 2023
1b4eb56
Merge pull request #41121 from mmusich/removeConsCast_SiStripFedCabli…
cmsbuild Mar 22, 2023
3e995be
Merge pull request #41095 from mandrenguyen/hiRelval2023
cmsbuild Mar 22, 2023
9d9b54f
Merge pull request #41119 from saumyaphor4252/alca-Include_TkAlRcds_i…
cmsbuild Mar 22, 2023
7530dfd
Merge pull request #41116 from mmusich/postPhase2AlignmentFollowUp
cmsbuild Mar 22, 2023
85f2e81
introduce SiStripNoisesAndBadCompsChecker
mmusich Mar 21, 2023
e4a92e9
fix peak mode noise payload in 2018 cosmics simulation
mmusich Mar 21, 2023
e4f9f02
adapt Tracker Alignment Payload Inspector for phase-2
mmusich Mar 17, 2023
1c72394
Add calculation of per SiPM time resolution to BtlElectronicsSim
fabiocos Mar 22, 2023
129dd03
[OPERATIONS] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
6fa8be9
[CORE] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
b9fa4db
[ALCA-DB] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
0f1b65f
[GEOMETRY] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
a5333c6
[DB-DQM] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
e6b708a
[ANALYSIS] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
5adddb6
[ALCA] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
7aa1c82
[DQM] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
72d9557
[SIMULATION] Various fixes/improvements for unit test
smuzaffar Mar 22, 2023
0a64a02
Merge pull request #41142 from smuzaffar/core-fix-unit-test9
cmsbuild Mar 23, 2023
02ab2d2
Merge pull request #41140 from smuzaffar/alca-db-fix-unit-test9
cmsbuild Mar 23, 2023
05f7b26
Merge pull request #41139 from smuzaffar/geometry-fix-unit-test9
cmsbuild Mar 23, 2023
6b6d12a
Merge pull request #41136 from smuzaffar/alca-fix-unit-test9
cmsbuild Mar 23, 2023
3d24e44
Merge pull request #41132 from smuzaffar/simulation-fix-unit-test9
cmsbuild Mar 23, 2023
324a045
Merge pull request #41143 from smuzaffar/operations-fix-unit-test9
cmsbuild Mar 23, 2023
055e45c
Merge pull request #41137 from smuzaffar/analysis-fix-unit-test9
cmsbuild Mar 23, 2023
0e46eac
Merge pull request #41130 from mmusich/adaptTkAlForPhase2
cmsbuild Mar 23, 2023
a5665d8
range-based loops in SiStripFedCablingFakeESSource
mmusich Mar 23, 2023
726b7b4
Merge pull request #41138 from smuzaffar/db-dqm-fix-unit-test9
cmsbuild Mar 23, 2023
9cb2d62
Merge pull request #41077 from sunilUIET/revertToRerecoGT
cmsbuild Mar 23, 2023
e292ad5
Merge pull request #41133 from smuzaffar/dqm-fix-unit-test9
cmsbuild Mar 23, 2023
e411661
Merge pull request #41131 from fabiocos/fc-btlresmodel131X
cmsbuild Mar 23, 2023
97005a9
Merge pull request #41048 from bsunanda/Phase2-hgx336C
cmsbuild Mar 23, 2023
46fdcaa
Merge pull request #41127 from mmusich/SiStripNoisesAndBadCompsChecker
cmsbuild Mar 23, 2023
caa3d84
Merge pull request #41057 from qyguo/PR_v3
cmsbuild Mar 23, 2023
dbfda5e
[ALCA-DB] Various fixes/improvements for unit test
smuzaffar Mar 23, 2023
a1bb21e
[GEOMETRY] Various fixes/improvements for unit test
smuzaffar Mar 23, 2023
7eb0834
[DB] Various fixes/improvements for unit test
smuzaffar Mar 23, 2023
0870dab
[ALCA] Various fixes/improvements for unit test
smuzaffar Mar 23, 2023
14e5edf
[DAQ] Various fixes/improvements for unit test
smuzaffar Mar 23, 2023
09485e6
[SIMULATION] Various fixes/improvements for unit test
smuzaffar Mar 23, 2023
c4381d1
Merge pull request #41036 from aloeliger/utmReinterpretCastFix
cmsbuild Mar 23, 2023
c9fe1fd
Merge pull request #41161 from smuzaffar/alca-db-fix-unit-test10
cmsbuild Mar 23, 2023
2c62392
Merge pull request #41159 from smuzaffar/geometry-fix-unit-test10
cmsbuild Mar 23, 2023
7c37c43
Merge pull request #41158 from smuzaffar/db-fix-unit-test10
cmsbuild Mar 23, 2023
17d5371
Merge pull request #41156 from smuzaffar/alca-fix-unit-test10
cmsbuild Mar 23, 2023
aed8028
Merge pull request #41155 from smuzaffar/daq-fix-unit-test10
cmsbuild Mar 23, 2023
568a0e7
Merge pull request #41151 from smuzaffar/simulation-fix-unit-test10
cmsbuild Mar 23, 2023
6ac2ad6
Merge pull request #41148 from mmusich/removeConsCast_SiStripFedCabli…
cmsbuild Mar 23, 2023
d16a1cc
Merge pull request #41120 from mmusich/fixPeakModeCosmicSimu_in_DBG_X…
cmsbuild Mar 23, 2023
19157e1
added test script to Skimming/test/test_EXOLLPJetHCAL_SKIM.py
Mar 23, 2023
33ce8f8
added EXOLLPJetHCAL skim (initial version)
Mar 17, 2023
d27dd46
clean up comments
Mar 17, 2023
2d767c4
bug fix
Mar 17, 2023
476de65
fixed hcal rechit collection
Mar 20, 2023
40abd1d
updated HLT path string
Mar 20, 2023
fd3e577
added test script to Skimming/test/test_EXOLLPJetHCAL_SKIM.py
Mar 23, 2023
5dec356
Merge branch 'dev-hcal-llp-skims' of https://github.com/kennedykiley/…
Mar 23, 2023
8b7a525
fixed issues with rebase, moved EXOLLPJetHCAL section to follow Delay…
Mar 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class RefitType(Enum):
####################################################################
process.load("Configuration.StandardSequences.FrontierConditions_GlobalTag_cff")
from Configuration.AlCa.GlobalTag import GlobalTag
process.GlobalTag = GlobalTag(process.GlobalTag, ('auto:phase2_realistic' if options.isPhase2 else 'auto:phase1_2022_realistic'), '')
process.GlobalTag = GlobalTag(process.GlobalTag, ('auto:phase2_realistic_T21' if options.isPhase2 else 'auto:phase1_2022_realistic'), '')

if _allFromGT:
print("############ testPVValidation_cfg.py: msg%-i: All is taken from GT")
Expand Down
5 changes: 1 addition & 4 deletions CalibCalorimetry/HcalAlgos/test/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,4 @@
<flags EDM_PLUGIN="1"/>
</library>

<bin name="testHcalPulseContainmentTest" file="TestDriver.cpp">
<flags TEST_RUNNER_ARGS=" /bin/bash CalibCalorimetry/HcalAlgos/test HcalPulseContainmentTest.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="testHcalPulseContainmentTest" command="HcalPulseContainmentTest.sh"/>
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
# Pass in name and status
function die { echo $1: status $2 ; exit $2; }

F1=${LOCAL_TEST_DIR}/HcalPulseContainmentTest_cfg.py
F1=${SCRAM_TEST_PATH}/HcalPulseContainmentTest_cfg.py
(cmsRun $F1 ) || die "Failure using $F1" $?
3 changes: 0 additions & 3 deletions CalibCalorimetry/HcalAlgos/test/TestDriver.cpp

This file was deleted.

7 changes: 1 addition & 6 deletions CalibTracker/SiPixelESProducers/test/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,4 @@
<flags EDM_PLUGIN="1"/>
</library>

<environment>
<bin file="testSiPixelFakeLorentzAngleESSource.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiPixelESProducers/test testSiPixelFakeLorentzAngleESSource.sh"/>
<use name="FWCore/Utilities"/>
</bin>
</environment>
<test name="testSiPixelFakeLorentzAngleESSource" command="testSiPixelFakeLorentzAngleESSource.sh"/>

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@ function die { echo $1: status $2 ; exit $2; }
echo "TESTING Fake Pixel Conditions Sources ..."

printf "TESTING SiPixelFakeLorentzAngleESSource (BPix) ...\n\n"
cmsRun ${LOCAL_TEST_DIR}/testSiPixelFakeLorentzAngleESSource_cfg.py isBPix=True || die "Failure testing SiPixelFakeLorentzAngleESSource (BPix)" $?
cmsRun ${SCRAM_TEST_PATH}/testSiPixelFakeLorentzAngleESSource_cfg.py isBPix=True || die "Failure testing SiPixelFakeLorentzAngleESSource (BPix)" $?

printf "TESTING SiPixelFakeLorentzAngleESSource (FPix) ...\n\n"
cmsRun ${LOCAL_TEST_DIR}/testSiPixelFakeLorentzAngleESSource_cfg.py isFPix=True || die "Failure testing SiPixelFakeLorentzAngleESSource (FPix)" $?
cmsRun ${SCRAM_TEST_PATH}/testSiPixelFakeLorentzAngleESSource_cfg.py isFPix=True || die "Failure testing SiPixelFakeLorentzAngleESSource (FPix)" $?

printf "TESTING SiPixelFakeLorentzAngleESSource (By Module) ...\n\n"
cmsRun ${LOCAL_TEST_DIR}/testSiPixelFakeLorentzAngleESSource_cfg.py isByModule=True || die "Failure testing SiPixelFakeLorentzAngleESSource (By Module)" $?
cmsRun ${SCRAM_TEST_PATH}/testSiPixelFakeLorentzAngleESSource_cfg.py isByModule=True || die "Failure testing SiPixelFakeLorentzAngleESSource (By Module)" $?

printf "TESTING SiPixelFakeLorentzAngleESSource (Phase-2) ...\n\n"
cmsRun ${LOCAL_TEST_DIR}/testSiPixelFakeLorentzAngleESSource_cfg.py isPhase2=True || die "Failure testing SiPixelFakeLorentzAngleESSource (Phase-2) " $?
cmsRun ${SCRAM_TEST_PATH}/testSiPixelFakeLorentzAngleESSource_cfg.py isPhase2=True || die "Failure testing SiPixelFakeLorentzAngleESSource (Phase-2) " $?
10 changes: 2 additions & 8 deletions CalibTracker/SiStripChannelGain/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,15 +1,9 @@
<environment>
<bin name="testSSTGainPCL_fromRECO" file="testSSTGain_PCL_FromRECO.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiStripChannelGain/test testSSTGain_PCL_FromRECO.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="testSSTGainPCL_fromRECO" command="testSSTGain_PCL_FromRECO.sh"/>
<bin name="checkMultiRunHarvestingOutput" file="checkMultiRunHarvesting.cpp">
<flags PRE_TEST="testSSTGainPCL_fromRECO"/>
<use name="rootmath"/>
<use name="roothistmatrix"/>
</bin>
<bin name="testSSTGainPCL_fromCalibTree" file="testSSTGain_PCL_FromCalibTree.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiStripChannelGain/test testSSTGain_PCL_FromCalibTree.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="testSSTGainPCL_fromCalibTree" command="testSSTGain_PCL_FromCalibTree.sh"/>
</environment>

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ COMMMAND=`xrdfs root://eoscms.cern.ch// locate ${REMOTE}/${FILE}`
STATUS=$?
echo "xrdfs command status = "$STATUS
if [ $STATUS -eq 0 ]; then
(cmsRun ${LOCAL_TEST_DIR}/Gains_CT_step1.py firstRun=${RUN} lastRun=${RUN} inputFiles=root://eoscms.cern.ch//$REMOTE/$FILE outputFile=PromptCalibProdSiStripGainsFromTree.root) || die 'Failure running cmsRun Gains_CT_step1.py firstRun=${RUN} lastRun=${RUN} inputFiles=root://eoscms.cern.ch//$REMOTE/$FILE outputFile=PromptCalibProdSiStripGainsFromTree.root' $?
(cmsRun ${LOCAL_TEST_DIR}/Gains_CT_step2.py inputFiles=file:PromptCalibProdSiStripGainsFromTree.root DQMOutput=True) || die 'Failure running cmsRun Gains_CT_step2.py inputFiles=file:PromptCalibProdSiStripGainsFromTree.root DQMOutput=True' $?
(cmsRun ${SCRAM_TEST_PATH}/Gains_CT_step1.py firstRun=${RUN} lastRun=${RUN} inputFiles=root://eoscms.cern.ch//$REMOTE/$FILE outputFile=PromptCalibProdSiStripGainsFromTree.root) || die 'Failure running cmsRun Gains_CT_step1.py firstRun=${RUN} lastRun=${RUN} inputFiles=root://eoscms.cern.ch//$REMOTE/$FILE outputFile=PromptCalibProdSiStripGainsFromTree.root' $?
(cmsRun ${SCRAM_TEST_PATH}/Gains_CT_step2.py inputFiles=file:PromptCalibProdSiStripGainsFromTree.root DQMOutput=True) || die 'Failure running cmsRun Gains_CT_step2.py inputFiles=file:PromptCalibProdSiStripGainsFromTree.root DQMOutput=True' $?
else
die "SKIPPING test, file ${FILE} not found" 0
fi

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash
# Pass in name and status
function die { echo $1: status $2 ; exit $2; }
(cmsRun ${LOCAL_TEST_DIR}/testSSTGain_PCL_FromRECO_cfg.py era=A) || die 'Failure running cmsRun testSSTGain_PCL_FromRECO_cfg.py era=A' $?
(cmsRun ${LOCAL_TEST_DIR}/testSSTGain_PCL_FromRECO_cfg.py era=B) || die 'Failure running cmsRun testSSTGain_PCL_FromRECO_cfg.py era=B' $?
(cmsRun ${LOCAL_TEST_DIR}/testSSTGain_HARVEST_FromRECO.py 0) || die 'Failure running cmsRun testSSTGain_HARVEST_FromRECO.py 0' $?
(cmsRun ${LOCAL_TEST_DIR}/testSSTGain_MultiRun_ALCAHARVEST.py globalTag=auto:run3_data_express) || die 'Failure running cmsRun testSSTGain_MultiRun_ALCAHARVEST.py 0' $?
(cmsRun ${SCRAM_TEST_PATH}/testSSTGain_PCL_FromRECO_cfg.py era=A) || die 'Failure running cmsRun testSSTGain_PCL_FromRECO_cfg.py era=A' $?
(cmsRun ${SCRAM_TEST_PATH}/testSSTGain_PCL_FromRECO_cfg.py era=B) || die 'Failure running cmsRun testSSTGain_PCL_FromRECO_cfg.py era=B' $?
(cmsRun ${SCRAM_TEST_PATH}/testSSTGain_HARVEST_FromRECO.py 0) || die 'Failure running cmsRun testSSTGain_HARVEST_FromRECO.py 0' $?
(cmsRun ${SCRAM_TEST_PATH}/testSSTGain_MultiRun_ALCAHARVEST.py globalTag=auto:run3_data_express) || die 'Failure running cmsRun testSSTGain_MultiRun_ALCAHARVEST.py 0' $?
7 changes: 1 addition & 6 deletions CalibTracker/SiStripCommon/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
<environment>
<bin file="testCalibTrackerSiStripCommon.cpp">
<flags TEST_RUNNER_ARGS=" /bin/bash CalibTracker/SiStripCommon/test test_all.sh"/>
<use name="FWCore/Utilities"/>
</bin>
</environment>
<test name="testCalibTrackerSiStripCommon" command="test_all.sh"/>

<use name="CalibTracker/SiStripCommon"/>
<library file="*.cc" name="CalibTrackerSiStripCommonTest">
Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions CalibTracker/SiStripCommon/test/test_all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
function die { echo $1: status $2 ; exit $2; }

echo "TESTING CalibTracker/SiStripCommon ..."
cmsRun ${LOCAL_TEST_DIR}/test_all_cfg.py || die "Failure running test_CalibTrackerSiStripCommon_cfg.py" $?
cmsRun ${LOCAL_TEST_DIR}/testProduceCalibrationTree_cfg.py maxEvents=10 unitTest=True || die "Failure running produceCalibrationTree_template_cfg.py" $?
cmsRun ${SCRAM_TEST_PATH}/test_all_cfg.py || die "Failure running test_CalibTrackerSiStripCommon_cfg.py" $?
cmsRun ${SCRAM_TEST_PATH}/testProduceCalibrationTree_cfg.py maxEvents=10 unitTest=True || die "Failure running produceCalibrationTree_template_cfg.py" $?
Original file line number Diff line number Diff line change
Expand Up @@ -95,18 +95,13 @@ SiStripFedCabling* SiStripFedCablingFakeESSource::make(const SiStripFedCablingRc
bool insufficient = false;
Feds::const_iterator ifed = feds.begin();
uint16_t fed_ch = 0;
for (std::vector<SiStripFecCrate>::const_iterator icrate = fec_cabling->crates().begin();
icrate != fec_cabling->crates().end();
icrate++) {
for (std::vector<SiStripFec>::const_iterator ifec = icrate->fecs().begin(); ifec != icrate->fecs().end(); ifec++) {
for (std::vector<SiStripRing>::const_iterator iring = ifec->rings().begin(); iring != ifec->rings().end();
iring++) {
for (std::vector<SiStripCcu>::const_iterator iccu = iring->ccus().begin(); iccu != iring->ccus().end();
iccu++) {
for (std::vector<SiStripModule>::const_iterator imod = iccu->modules().begin(); imod != iccu->modules().end();
imod++) {
for (auto& icrate : fec_cabling->crates()) {
for (auto& ifec : icrate.fecs()) {
for (auto& iring : ifec.rings()) {
for (auto& iccu : iring.ccus()) {
for (auto& imod : iccu.modules()) {
if (populateAllFeds) {
for (uint16_t ipair = 0; ipair < imod->nApvPairs(); ipair++) {
for (uint16_t ipair = 0; ipair < imod.nApvPairs(); ipair++) {
if (ifed == feds.end()) {
fed_ch++;
ifed = feds.begin();
Expand All @@ -116,30 +111,30 @@ SiStripFedCabling* SiStripFedCablingFakeESSource::make(const SiStripFedCablingRc
break;
}

std::pair<uint16_t, uint16_t> addr = imod->activeApvPair(imod->lldChannel(ipair));
std::pair<uint16_t, uint16_t> addr = imod.activeApvPair(imod.lldChannel(ipair));
SiStripModule::FedChannel fed_channel((*ifed) / 16 + 1, // 16 FEDs per crate, numbering starts from 1
(*ifed) % 16 + 2, // FED slot starts from 2
*ifed,
fed_ch);
const_cast<SiStripModule&>(*imod).fedCh(addr.first, fed_channel);
imod.fedCh(addr.first, fed_channel);
ifed++;
}
} else {
// Patch introduced by D.Giordano 2/12/08
//to reproduce the fake cabling used in 2x
//that was designed to fill each fed iteratively
//filling all channels of a fed before going to the next one
if (96 - fed_ch < imod->nApvPairs()) {
if (96 - fed_ch < imod.nApvPairs()) {
ifed++;
fed_ch = 0;
} // move to next FED
for (uint16_t ipair = 0; ipair < imod->nApvPairs(); ipair++) {
std::pair<uint16_t, uint16_t> addr = imod->activeApvPair((*imod).lldChannel(ipair));
for (uint16_t ipair = 0; ipair < imod.nApvPairs(); ipair++) {
std::pair<uint16_t, uint16_t> addr = imod.activeApvPair(imod.lldChannel(ipair));
SiStripModule::FedChannel fed_channel((*ifed) / 16 + 1, // 16 FEDs per crate, numbering starts from 1
(*ifed) % 16 + 2, // FED slot starts from 2
(*ifed),
fed_ch);
const_cast<SiStripModule&>(*imod).fedCh(addr.first, fed_channel);
imod.fedCh(addr.first, fed_channel);
fed_ch++;
}
}
Expand Down
8 changes: 1 addition & 7 deletions CalibTracker/SiStripESProducers/test/BuildFile.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,4 @@
<flags EDM_PLUGIN="1"/>
</library>

<environment>
<bin file="testCalibTrackerSiStripESProducersByHand.cpp">
<flags TEST_RUNNER_ARGS=" /bin/bash CalibTracker/SiStripESProducers/test/python testBadComponents_byHand.sh"/>
<use name="FWCore/Utilities"/>
</bin>

</environment>
<test name="testCalibTrackerSiStripESProducersByHand" command="python/testBadComponents_byHand.sh"/>
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
function die { echo $1: status $2 ; exit $2; }

echo "TESTING CalibTracker/SiStripESProducers ..."
cmsRun ${LOCAL_TEST_DIR}/SiStripBadAPVListBuilder_byHand_cfg.py || die "Failure running SiStripBadAPVListBuilder_byHand_cfg.py" $?
cmsRun ${SCRAM_TEST_PATH}/python/SiStripBadAPVListBuilder_byHand_cfg.py || die "Failure running SiStripBadAPVListBuilder_byHand_cfg.py" $?

This file was deleted.

5 changes: 1 addition & 4 deletions CalibTracker/SiStripHitEfficiency/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
<bin name="testSiStripHitEfficiency" file="TestDriver.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiStripHitEfficiency/test test_SiStripHitEfficiency.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="testSiStripHitEfficiency" command="test_SiStripHitEfficiency.sh"/>
2 changes: 0 additions & 2 deletions CalibTracker/SiStripHitEfficiency/test/TestDriver.cpp

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ if [ "${SCRAM_TEST_NAME}" != "" ] ; then
fi

echo -e "Testing SiStripHitEfficencyWorker \n\n"
cmsRun ${LOCAL_TEST_DIR}/testHitEffWorker.py isUnitTest=True || die 'failed running testHitEffWorker.py' $?
cmsRun ${SCRAM_TEST_PATH}/testHitEffWorker.py isUnitTest=True || die 'failed running testHitEffWorker.py' $?

echo -e "Testing SiStripHitEfficencyHarvester \n\n"
cmsRun ${LOCAL_TEST_DIR}/testHitEffHarvester.py isUnitTest=True || die 'failed running testHitEffHarvester.py' $?
cmsRun ${SCRAM_TEST_PATH}/testHitEffHarvester.py isUnitTest=True || die 'failed running testHitEffHarvester.py' $?

echo -e " testing tSiStripHitEffFromCalibTree \n\n"
cmsRun ${LOCAL_TEST_DIR}/testSiStripHitEffFromCalibTree_cfg.py inputFiles=HitEffTree.root runNumber=325172 || die 'failed running testSiStripHitEffFromCalibTree_cfg.py' $?
cmsRun ${SCRAM_TEST_PATH}/testSiStripHitEffFromCalibTree_cfg.py inputFiles=HitEffTree.root runNumber=325172 || die 'failed running testSiStripHitEffFromCalibTree_cfg.py' $?

echo -e "Done with the tests!"
5 changes: 1 addition & 4 deletions CalibTracker/SiStripHitResolution/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
<bin name="testSiStripHitResolution" file="TestDriver.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiStripHitResolution/test test_SiStripHitResolution.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="testSiStripHitResolution" command="test_SiStripHitResolution.sh"/>
2 changes: 0 additions & 2 deletions CalibTracker/SiStripHitResolution/test/TestDriver.cpp

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,20 @@ if [ "${SCRAM_TEST_NAME}" != "" ] ; then
fi

echo -e "Testing SiStripHitEfficencyWorker \n\n"
cmsRun ${LOCAL_TEST_DIR}/SiStripHitResol_test.py isUnitTest=True || die 'failed running SiStripHitResol_test.py' $?
cmsRun ${SCRAM_TEST_PATH}/SiStripHitResol_test.py isUnitTest=True || die 'failed running SiStripHitResol_test.py' $?

echo -e "Testing CPEanconfig.py \n\n"
cmsRun ${LOCAL_TEST_DIR}/CPEanconfig.py isUnitTest=True || die 'failed running CPEanconfig.py' $?
cmsRun ${SCRAM_TEST_PATH}/CPEanconfig.py isUnitTest=True || die 'failed running CPEanconfig.py' $?

echo -e "Testing SiStripHitResolutionFromCalibTree_cfg.py \n\n"
cmsRun ${LOCAL_TEST_DIR}/SiStripHitResolutionFromCalibTree_cfg.py || die 'failed running SiStripHitResolutionFromCalibTree_cfg.py' $?
cmsRun ${SCRAM_TEST_PATH}/SiStripHitResolutionFromCalibTree_cfg.py || die 'failed running SiStripHitResolutionFromCalibTree_cfg.py' $?

### To be implemented

#echo -e "Testing SiStripHitEfficencyHarvester \n\n"
#cmsRun ${LOCAL_TEST_DIR}/testHitEffHarvester.py isUnitTest=True || die 'failed running testHitEffHarvester.py' $?
#cmsRun ${SCRAM_TEST_PATH}/testHitEffHarvester.py isUnitTest=True || die 'failed running testHitEffHarvester.py' $?

#echo -e " testing tSiStripHitEffFromCalibTree \n\n"
#cmsRun ${LOCAL_TEST_DIR}/testSiStripHitEffFromCalibTree_cfg.py inputFiles=HitEffTree.root runNumber=325172 || die 'failed running testSiStripHitEffFromCalibTree_cfg.py' $?
#cmsRun ${SCRAM_TEST_PATH}/testSiStripHitEffFromCalibTree_cfg.py inputFiles=HitEffTree.root runNumber=325172 || die 'failed running testSiStripHitEffFromCalibTree_cfg.py' $?

echo -e "Done with the tests!"
11 changes: 2 additions & 9 deletions CalibTracker/SiStripQuality/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,2 @@
<bin name="test_SiStripQualityStatistics" file="TestDriver.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiStripQuality/test test_SiStripQualityStatistics.sh"/>
<use name="FWCore/Utilities"/>
</bin>

<bin name="test_makeMergedBadComponentsWithFedErr" file="TestDriver.cpp">
<flags TEST_RUNNER_ARGS="/bin/bash CalibTracker/SiStripQuality/test test_makeMergedBadComponentsWithFedErr.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="test_SiStripQualityStatistics" command="test_SiStripQualityStatistics.sh"/>
<test name="test_makeMergedBadComponentsWithFedErr" command="test_makeMergedBadComponentsWithFedErr.sh"/>
2 changes: 0 additions & 2 deletions CalibTracker/SiStripQuality/test/TestDriver.cpp

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
# Pass in name and status
function die { echo $1: status $2 ; exit $2; }
(cmsRun ${LOCAL_TEST_DIR}/test_SiStripQualityStatistics_cfg.py) || die 'Failure running cmsRun test_SiStripQualityStatistics_cfg.py' $?
(cmsRun ${SCRAM_TEST_PATH}/test_SiStripQualityStatistics_cfg.py) || die 'Failure running cmsRun test_SiStripQualityStatistics_cfg.py' $?
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ dqmFile="/eos/cms/store/group/comm_dqm/DQMGUI_data/Run2018/ZeroBias/R0003191xx/D
if [ ! -f "${dqmFile}" ]; then
die "SKIPPING test, file ${dqmFile} not found" 0
fi
runStartTime=$( (python "${LOCAL_TEST_DIR}/cfg/getRunStartTime.py" "${run}" | tail -n1 ) || die "Failed to get run start time" $? )
runStartTime=$( (python "${SCRAM_TEST_PATH}/cfg/getRunStartTime.py" "${run}" | tail -n1 ) || die "Failed to get run start time" $? )
echo "DEBUG: Run ${run} started at ${runStartTime}"
(cmsRun "${LOCAL_TEST_DIR}/cfg/makeMergeBadComponentPayload_example_cfg.py" globalTag=auto:run3_data_prompt runNumber="${run}" runStartTime="${runStartTime}" dqmFile="${dqmFile}" dbfile="test.db" outputTag="TestBadComponents" ) || die "Failure running cmsRun makeMergeBadComponentPayload_example_cfg.py" $?
(cmsRun "${SCRAM_TEST_PATH}/cfg/makeMergeBadComponentPayload_example_cfg.py" globalTag=auto:run3_data_prompt runNumber="${run}" runStartTime="${runStartTime}" dqmFile="${dqmFile}" dbfile="test.db" outputTag="TestBadComponents" ) || die "Failure running cmsRun makeMergeBadComponentPayload_example_cfg.py" $?
# get the hash
plEntryLn=$( (conddb --db sqlite_file:test.db list TestBadComponents | grep SiStripBadStrip) || die "Failed to get payload" $? )
read -a plEntryLn_split <<< "${plEntryLn}"
Expand Down
5 changes: 1 addition & 4 deletions Calibration/LumiAlCaRecoProducers/test/BuildFile.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
<bin file="test.cpp" name="TestCalibrationLumiAlCaRecoProducers">
<flags TEST_RUNNER_ARGS=" /bin/bash Calibration/LumiAlCaRecoProducers/test test.sh"/>
<use name="FWCore/Utilities"/>
</bin>
<test name="TestCalibrationLumiAlCaRecoProducers" command="test.sh"/>
3 changes: 0 additions & 3 deletions Calibration/LumiAlCaRecoProducers/test/test.cpp

This file was deleted.

2 changes: 1 addition & 1 deletion Calibration/LumiAlCaRecoProducers/test/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@

function die { echo $1: status $2 ; exit $2; }

cmsRun --parameter-set ${LOCAL_TEST_DIR}/test_cfg.py || die 'Failed in test_cfg.py' $?
cmsRun --parameter-set ${SCRAM_TEST_PATH}/test_cfg.py || die 'Failed in test_cfg.py' $?
Loading