HLT menu development for `12_4_X` (2/N) by missirol · Pull Request #38242 · cms-sw/cmssw

missirol · 2022-06-04T06:55:50Z

backport of #38241

PR description:

Development of HLT menus for CMSSW_12_4_X.

Includes the integration of the following JIRA tickets.

CMSHLT-2273: [BPH] Double-electron triggers for R(X)-type analyses (partly integrated)
CMSHLT-2281: [HIG] Update of DijetVBF+2Tau trigger
CMSHLT-2282: [EXO] PFMETNoMu trigger with HF cleaning + low-pT double-photon triggers (partly integrated)
CMSHLT-2284: [HIG] Backup and control triggers for 2Tau+Jet trigger
CMSHLT-2285: [HIG] Control triggers for VBF+2Tau trigger
CMSHLT-2289: [TAU] Update of VBF+2Tau triggers
CMSHLT-2291: [B2G] SingleJet and DiJet Triggers on AK8 jets with softdrop-mass cut
CMSHLT-2306: [TOP] Update of DeepJet WP for HT+6Jet+1BTag trigger
CMSHLT-2308: [BPH] Update of triggers for Tau->3Mu search (amended with respect to #38108)
CMSHLT-2314: [JME] Low-pT single-photon trigger for jet-energy corrections
CMSHLT-2316: [TSG] run Pixel DQM (CPU-vs-GPU) inside the HLT
CMSHLT-2321: [EXO] Backup and monitoring triggers for displaced-dimuon searches
CMSHLT-2324: [TSG] Naming: changed AlCaLumiPixelCounts to AlCaLumiPixelsCounts
CMSHLT-2325: [TRK,AlCa,TSG] Update of DQMOnlineBeamspot EventContent and FEDSelector for TCDS
CMSHLT-2330: [TAU,HIG] Naming: changed "DeepTauIso" label to "DeepTau"
CMSHLT-2333: [EGM,HIG] Naming: removed "NoPixelVeto" label from Diphoton Paths (partly integrated)

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#38241

Development of HLT menus for 2022 pp data-taking.

cmsbuild · 2022-06-04T06:56:16Z

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from HLT menu development for 12_4_X (2/N) [12_5_X] #38241

missirol · 2022-06-04T06:57:23Z

enable gpu

To better test the update of the DQM path, which only runs on GPU.

missirol · 2022-06-04T06:58:01Z

please test

missirol · 2022-06-04T09:03:32Z

please abort

missirol · 2022-06-04T12:05:54Z

hold

See #38241 (comment).

cmsbuild · 2022-06-04T12:06:11Z

Pull request has been put on hold by @missirol
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild · 2022-06-06T08:38:23Z

Pull request #38242 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

cmsbuild · 2022-06-06T17:22:33Z

Pull request #38242 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

cmsbuild · 2022-06-07T16:56:13Z

Pull request #38242 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

tvami · 2022-06-08T21:46:19Z

@cmsbuild , please test with #38293

missirol · 2022-06-08T22:08:12Z

unhold

missirol · 2022-06-09T08:52:55Z

It seems that some of the tests are having trouble finishing.

@smuzaffar , what you would suggest to do in this case? Does one need to restart the tests from scratch?

smuzaffar · 2022-06-09T09:01:06Z

The pending test requires a HTCondor based GPU node. 4 hours ago, cmsbot has requested the allocation of such node but sometimes it can take few hours to get this type of resource. I would suggest to wait few more hours

cmsbuild · 2022-06-09T09:56:50Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-502456/25376/summary.html
COMMIT: 7a91d7a
CMSSW: CMSSW_12_4_X_2022-06-08-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38242/25376/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-502456/25376/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-502456/25376/git-merge-result

GPU Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 3 failed jobs
DQMHistoTests: Total files compared: 4
DQMHistoTests: Total histograms compared: 19864
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 19856
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
Checked 12 log files, 9 edm output root files, 4 DQM output files
TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3668754
DQMHistoTests: Total failures: 285
DQMHistoTests: Total nulls: 99
DQMHistoTests: Total successes: 3668348
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 6120.827999999999 KiB( 49 files compared)
DQMHistoSizes: changed ( 1000.0 ): 1810.459 KiB AlCaReco/TkAlJetHT
DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Errors
DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 11634.0,... ): 438.834 KiB HLT/JME
DQMHistoSizes: changed ( 11634.0,... ): 215.022 KiB HLT/TAU
DQMHistoSizes: changed ( 11634.0,... ): 111.191 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 11634.0,... ): -54.365 KiB HLT/HIG
DQMHistoSizes: changed ( 11634.0,... ): 22.390 KiB HLT/EGM
DQMHistoSizes: changed ( 11634.0,... ): -13.316 KiB HLT/Exotica
DQMHistoSizes: changed ( 11634.0,... ): -6.582 KiB HLT/Higgs
DQMHistoSizes: changed ( 11634.0 ): ...
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: found differences in 6 / 49 workflows

missirol · 2022-06-09T10:15:20Z

+hlt

differences in PR-tests outputs are in line with the updates to the GRun HLT menu
some differences are not fully understood (by me), namely diffs in HLT/SiStrip ; the same as written for the original PR in applies (suggesting that the effect is reproducible), see HLT menu development for 12_4_X (2/N) [12_5_X] #38241 (comment);
this PR should be merged only after [12_4_X] Include EGM and L1T tags in mcRun3 and data GTs #38293 (but for the same IB, possibly)

cmsbuild · 2022-06-09T10:15:42Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-06-10T07:56:03Z

+1

cmsbuild added this to the CMSSW_12_4_X milestone Jun 4, 2022

cmsbuild added backport hlt-pending orp-pending pending-signatures tests-pending labels Jun 4, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 4, 2022

cmsbuild added tests-pending and removed tests-started labels Jun 4, 2022

cmsbuild added the hold label Jun 4, 2022

missirol force-pushed the HLTdevelopment124X branch from ded64f8 to 3a94452 Compare June 6, 2022 08:38

missirol force-pushed the HLTdevelopment124X branch from 3a94452 to 802c686 Compare June 6, 2022 17:22

HLT menu development for 12_4_X

7a91d7a

missirol force-pushed the HLTdevelopment124X branch from 802c686 to 7a91d7a Compare June 7, 2022 16:55

missirol mentioned this pull request Jun 8, 2022

[12_4_X] Add GEM ChMap to all GTs and rename phase1_2021*to phase1_2022* #38265

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 8, 2022

cmsbuild removed the hold label Jun 8, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 9, 2022

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Jun 9, 2022

cmsbuild added backport-ok and removed backport labels Jun 9, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 10, 2022

cmsbuild merged commit ee16363 into cms-sw:CMSSW_12_4_X Jun 10, 2022

missirol deleted the HLTdevelopment124X branch June 10, 2022 17:28

cmsbuild mentioned this pull request Jun 10, 2022

[12_4_X] Fix ThroughputServiceClient.cc unsigned variables overflow #38317

Merged

missirol changed the title ~~HLT menu development for 12_4_X~~ HLT menu development for 12_4_X (2/N) Jun 12, 2022

Conversation

missirol commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

If this PR is a backport, please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Jun 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

missirol commented Jun 4, 2022

Uh oh!

cmsbuild commented Jun 4, 2022

Uh oh!

cmsbuild commented Jun 6, 2022

Uh oh!

cmsbuild commented Jun 6, 2022

Uh oh!

cmsbuild commented Jun 7, 2022

Uh oh!

tvami commented Jun 8, 2022

Uh oh!

missirol commented Jun 8, 2022

Uh oh!

missirol commented Jun 9, 2022

Uh oh!

smuzaffar commented Jun 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 9, 2022

GPU Comparison Summary

Comparison Summary

Uh oh!

missirol commented Jun 9, 2022

Uh oh!

cmsbuild commented Jun 9, 2022

Uh oh!

qliphy commented Jun 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

missirol commented Jun 4, 2022 •

edited

Loading

cmsbuild commented Jun 4, 2022 •

edited

Loading

smuzaffar commented Jun 9, 2022 •

edited

Loading