Speed-up seed/dup. cleaning mkFit #37122

leonardogiannini · 2022-03-02T20:55:04Z

PR description:

The seed cleaning algorithm (used in initial, high pT triplet, detached quad, and triplet) and the duplicate cleaning used in the pixelLess iteration are updated to reduce the processing time, while the physics is unchanged.

the seed cleaning is updated from an N^2 comparison of all the pairs to a comparison of the tracks that can be approximately
compatible for removal only. The tracks are binned in phi and eta and for each track, the comparison is made only inside compatible bins
the duplicate cleaning consisted of a nested loop comparing hits. The new algorithm uses 2 simple loops per track: 1 to map hits to tracks and the second to find all the tracks sharing hits with the one examined (similarly to TrajectoryCleanerBySharedHits)

The seed cleaning update is described here:
Jan 31 update

The duplicate cleaning is mentioned here (p.23):
Feb 14 update

PR validation:

The physics is validated with TTbar PU50, where blue is before PR and red is after PR

http://legianni.web.cern.ch/legianni/plots-PR37122/

CPU profiling with igprof can be found here

old
global
seed cleaning
dup cleaning
new
global
seed cleaning
dup cleaning

This was broken as struct/union with raw unsigned construct in struct binnor::B_pair got removed during CMSSW review process. 'raw' was actually used for sorting but this never showd up as the templates did not get instantianted, i.e., binnor was not used in cmssw. Here we remove explicit bin1/2 variables with specified bit-size and replace them with a single unsigned packed_value and provide hand-written bit-shifting / masking for bin-data access.

…(template type X) to start with a clearer from_X_...

Remove commented-out demonstration code.

cmsbuild · 2022-03-02T21:01:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37122/28645

This PR adds an extra 28KB to repository

cmsbuild · 2022-03-02T21:01:55Z

A new Pull Request was created by @leonardogiannini for master.

It involves the following packages:

RecoTracker/MkFitCMS (reconstruction)
RecoTracker/MkFitCore (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2022-03-02T21:04:32Z

@cmsbuild please test

cmsbuild · 2022-03-03T01:25:39Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8de885/22785/summary.html
COMMIT: 8cf58cd
CMSSW: CMSSW_12_3_X_2022-03-02-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37122/22785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5790 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3990927
DQMHistoTests: Total failures: 13337
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3977567
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 204 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

slava77 · 2022-03-07T14:07:21Z

@cms-sw/reconstruction-l2
it would be nice to get this in pre6

perrotta · 2022-03-07T14:27:49Z

urgent

@cms-sw/reconstruction-l2 it would be nice to get this in pre6

clacaputo · 2022-03-07T15:17:31Z

assign @cms-sw/tracking-pog-l2

clacaputo · 2022-03-07T17:12:20Z

assign @cms-sw/tracking-pog-l2

Seems like the tag didn't work.
Concerning the PR, no comments on the code, but still checking the RECO differences in the test (although they seem minimal)
About the profiling, how many events did you use @leonardogiannini ?

makortel · 2022-03-07T17:17:46Z

assign @cms-sw/tracking-pog-l2

Seems like the tag didn't work

It would need to be without @cms-sw/, i.e. assign tracking-pog-l2.

leonardogiannini · 2022-03-07T17:52:49Z

assign @cms-sw/tracking-pog-l2

Seems like the tag didn't work. Concerning the PR, no comments on the code, but still checking the RECO differences in the test (although they seem minimal) About the profiling, how many events did you use @leonardogiannini ?

@clacaputo 100 evts with TTbar PU 50

clacaputo · 2022-03-07T18:47:20Z

assign tracking-pog-l2

clacaputo · 2022-03-07T19:49:14Z

+reconstruction

mkFit seed cleaning algorithm and the duplicate cleaning updated
reco changes observed, but minimal
processing time reduced

cmsbuild · 2022-03-07T19:49:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2022-03-08T16:46:17Z

assign tracking-pog

cmsbuild · 2022-03-08T16:48:12Z

New categories assigned: tracking-pog

@mmusich,@mtosi,@vmariani you have been requested to review this Pull request/Issue and eventually sign? Thanks

mmusich

not necessarily needing to be followed-up.

mmusich · 2022-03-08T16:49:03Z

RecoTracker/MkFitCMS/src/MkStdSeqs.cc


+      axis_pow2_u1<float, unsigned short, 16, 8> ax_phi(-Const::PI, Const::PI);
+      axis<float, unsigned short, 8, 8> ax_eta(-3.0, 3.0, 30u);
+      binnor<unsigned int, decltype(ax_phi), decltype(ax_eta), 24, 8> phi_eta_binnor(ax_phi, ax_eta);


usual set of hard-coded constants.

mmusich · 2022-03-08T16:49:52Z

RecoTracker/MkFitCMS/src/MkStdSeqs.cc

+            continue;
+          int a = trk.getHitLyr(i);
+          int b = trk.getHitIdx(i);
+          hitMap.insert(std::make_pair(b * 1000 + a, i > 0 ? itrack : -itrack));  //negative for first hit in trk


what's 1000?

a way to write layer and hit id in a single int.

I know, I commented already here: #36546 (comment), not sure if it's in the plans to document it.

mmusich · 2022-03-08T17:23:44Z

+1

this update concerning speed-up of the seed cleaning algo has been agreed and discussed already couple of times at the tracking pog meeting: 1 2

cmsbuild · 2022-03-08T17:24:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-03-09T00:31:43Z

+1

osschar and others added 7 commits March 2, 2022 12:13

speed up duplicate and seed cleaning

6f063c6

improved code style and sync with cmssw master

ae59e20

improved code (except for binnor)

dd1e7cb

Rename value/pair conversions functions starting with capital letter …

c634fc4

…(template type X) to start with a clearer from_X_...

Incorporate comments from @srlantz.

e918c81

Remove commented-out demonstration code.

code-format

8cf58cd

cmsbuild added this to the CMSSW_12_3_X milestone Mar 2, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 2, 2022

leonardogiannini changed the title ~~Speedup cleaning 12 3 x~~ Speed-up seed/dup. cleaning mkFit Mar 2, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 2, 2022

cmsbuild added tests-started and removed tests-pending labels Mar 2, 2022

cmsbuild added tests-approved and removed tests-started labels Mar 3, 2022

cmsbuild added the urgent label Mar 7, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Mar 7, 2022

cmsbuild added pending-signatures tracking-pog-pending and removed fully-signed labels Mar 8, 2022

mmusich reviewed Mar 8, 2022

View reviewed changes

cmsbuild added fully-signed tracking-pog-approved and removed pending-signatures tracking-pog-pending labels Mar 8, 2022

cmsbuild added orp-approved and removed orp-pending labels Mar 9, 2022

cmsbuild merged commit 2dbc625 into cms-sw:master Mar 9, 2022

This was referenced Mar 9, 2022

[G4 VECGEOM] Geant4 update to 11.0.1 patch cms-sw/cmsdist#7678

Merged

[G4] Geant4 update to 11.0.1 patch cms-sw/cmsdist#7679

Merged

This was referenced Apr 8, 2022

speed up duplicate and seed cleaning trackreco/cmssw#82

Closed

Dup clean bins trackreco/mkFit#392

Closed

modify find_duplicates_sharedhits trackreco/mkFit#393

Closed

seed cleaning in eta-phi bins trackreco/mkFit#391

Closed

Speed-up seed/dup. cleaning mkFit #37122

Speed-up seed/dup. cleaning mkFit #37122

Uh oh!

Conversation

leonardogiannini commented Mar 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Mar 2, 2022

Uh oh!

cmsbuild commented Mar 2, 2022

Uh oh!

slava77 commented Mar 2, 2022

Uh oh!

cmsbuild commented Mar 3, 2022

Comparison Summary

Uh oh!

slava77 commented Mar 7, 2022

Uh oh!

perrotta commented Mar 7, 2022

Uh oh!

clacaputo commented Mar 7, 2022

Uh oh!

clacaputo commented Mar 7, 2022

Uh oh!

makortel commented Mar 7, 2022

Uh oh!

leonardogiannini commented Mar 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clacaputo commented Mar 7, 2022

Uh oh!

clacaputo commented Mar 7, 2022

Uh oh!

cmsbuild commented Mar 7, 2022

Uh oh!

mmusich commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Mar 8, 2022

Uh oh!

mmusich left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mmusich Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

mmusich Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

leonardogiannini Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

mmusich Mar 8, 2022

Choose a reason for hiding this comment

Uh oh!

mmusich commented Mar 8, 2022

Uh oh!

cmsbuild commented Mar 8, 2022

Uh oh!

qliphy commented Mar 9, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

leonardogiannini commented Mar 2, 2022 •

edited

Loading

leonardogiannini commented Mar 7, 2022 •

edited

Loading

mmusich commented Mar 8, 2022 •

edited

Loading

mmusich left a comment •

edited

Loading