Skip to content

Fixed bug which was crashing ROOT in fitting empty histograms #35903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 3 commits into from
Nov 2, 2021
Merged

Fixed bug which was crashing ROOT in fitting empty histograms #35903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57435d9
Fixed bug which was crashing ROOT in fitting empty histograms
dinardo Oct 29, 2021
9266bde
Added modification to cfg file for BeamPixel monitor
dinardo Oct 29, 2021
4d23ea0
Performed code checks
dinardo Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions DQM/BeamMonitor/plugins/Vx3DHLTAnalyzer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1239,7 +1239,8 @@ void Vx3DHLTAnalyzer::dqmEndLuminosityBlock(const LuminosityBlock& lumiBlock, co
}
}
myGaussFit->SetRange(minXfit - (maxXfit - minXfit) / 2., maxXfit + (maxXfit - minXfit) / 2.);
Vx_X_Fit->getTH1()->Fit(myGaussFit, "QRL");
if (Vx_X_Fit->getTH1()->GetEntries() > 0)
Vx_X_Fit->getTH1()->Fit(myGaussFit, "QRL");

myGaussFit->SetParameter(0, Vx_Y_Fit->getTH1()->GetMaximum());
myGaussFit->SetParameter(1, Vx_Y_Fit->getTH1()->GetMean());
Expand All @@ -1259,7 +1260,8 @@ void Vx3DHLTAnalyzer::dqmEndLuminosityBlock(const LuminosityBlock& lumiBlock, co
}
}
myGaussFit->SetRange(minXfit - (maxXfit - minXfit) / 2., maxXfit + (maxXfit - minXfit) / 2.);
Vx_Y_Fit->getTH1()->Fit(myGaussFit, "QRL");
if (Vx_Y_Fit->getTH1()->GetEntries() > 0)
Vx_Y_Fit->getTH1()->Fit(myGaussFit, "QRL");

myGaussFit->SetParameter(0, Vx_Z_Fit->getTH1()->GetMaximum());
myGaussFit->SetParameter(1, Vx_Z_Fit->getTH1()->GetMean());
Expand All @@ -1279,7 +1281,8 @@ void Vx3DHLTAnalyzer::dqmEndLuminosityBlock(const LuminosityBlock& lumiBlock, co
}
}
myGaussFit->SetRange(minXfit - (maxXfit - minXfit) / 2., maxXfit + (maxXfit - minXfit) / 2.);
Vx_Z_Fit->getTH1()->Fit(myGaussFit, "QRL");
if (Vx_Z_Fit->getTH1()->GetEntries() > 0)
Vx_Z_Fit->getTH1()->Fit(myGaussFit, "QRL");

delete myGaussFit;
} else if ((nLumiFit != 0) && (lumiCounter % nLumiFit != 0) && (beginTimeOfFit != 0) && (runNumber != 0)) {
Expand Down
4 changes: 2 additions & 2 deletions DQM/Integration/python/clients/beampixel_dqm_sourceclient-live_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import FWCore.ParameterSet.Config as cms

import sys
from Configuration.Eras.Era_Run2_2018_cff import Run2_2018
process = cms.Process("BeamPixel", Run2_2018)
from Configuration.Eras.Era_Run3_cff import Run3
process = cms.Process("BeamMonitor", Run3)

unitTest = False
if 'unitTest=True' in sys.argv:
Expand Down