Skip to content

Fix for multiprocessing in RecoTrack Validation script [12.1.X] #35894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 1 commit into from
Nov 2, 2021
Merged

Fix for multiprocessing in RecoTrack Validation script [12.1.X] #35894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Validation/RecoTrack/python/plotting/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def _setStyle():
def _getObject(tdirectory, name):
obj = tdirectory.Get(name)
if not obj:
print("Did not find {obj} from {dir}".format(obj=name, dir=tdirectory.GetPath()))
if verbose:
print("Did not find {obj} from {dir}".format(obj=name, dir=tdirectory.GetPath()))
return None
return obj

Expand Down
3 changes: 1 addition & 2 deletions Validation/RecoTrack/python/plotting/validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,6 +1201,7 @@ def _doPlotsForPlotter(self, plotter, sample, limitSubFoldersOnlyTo=None):
if not os.path.exists(newdir):
os.makedirs(newdir, exist_ok=True)

plotterFolder.create(self._openFiles, self._labels, dqmSubFolder)
p = multiprocessing.Process(target=self._doPlots, args=(plotterFolder, dqmSubFolder, newsubdir, newdir, iProc, return_dict))
proc.append((plotterFolder, dqmSubFolder, p))
p.start()
Expand Down Expand Up @@ -1294,7 +1295,6 @@ def doPlots(self, plotters, plotterDrawArgs={}, **kwargs):
self._openFiles = []

def _doPlots(self, plotterFolder, dqmSubFolder, newsubdir, newdir, iProc, return_dict):
plotterFolder.create(self._openFiles, self._labels, dqmSubFolder)
fileList = plotterFolder.draw(directory=newdir, **self._plotterDrawArgs)

if len(fileList) == 0:
Expand Down Expand Up @@ -1362,7 +1362,6 @@ def doPlots(self, plotters, plotterDrawArgs={}, **kwargs):
self._openFiles = []

def _doPlots(self, plotterFolder, dqmSubFolder, newsubdir, newdir, iProc, return_dict):
plotterFolder.create(self._openFiles, self._labels, dqmSubFolder)
fileList = plotterFolder.draw(directory=newdir, **self._plotterDrawArgs)

# check if plots are produced
Expand Down