Skip to content

Fix thread-safety problems with CSC simhit fitting in validation #35528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Oct 5, 2021
Merged

Fix thread-safety problems with CSC simhit fitting in validation #35528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a579064
Fix thread-safety problems with simhit fitting
Oct 3, 2021
35bcf43
Suggestion by Chris Jones
Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Validation/MuonHits/BuildFile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<use name="SimDataFormats/Vertex"/>
<use name="root"/>
<use name="clhep"/>
<use name="rootminuit"/>
<export>
<lib name="1"/>
</export>
13 changes: 9 additions & 4 deletions Validation/MuonHits/src/CSCSimHitMatcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "Validation/MuonHits/interface/CSCSimHitMatcher.h"
#include "TGraphErrors.h"
#include "TF1.h"
#include "TMinuitMinimizer.h"

using namespace std;

Expand All @@ -13,6 +14,10 @@ CSCSimHitMatcher::CSCSimHitMatcher(const edm::ParameterSet& ps, edm::ConsumesCol

simHitInput_ = iC.consumes<edm::PSimHitContainer>(simHitPSet_.getParameter<edm::InputTag>("inputTag"));
geomToken_ = iC.esConsumes<CSCGeometry, MuonGeometryRecord>();

//In order to make fitting ROOT histograms thread safe
// one must call this undocumented function
TMinuitMinimizer::UseStaticMinuit(false);
}

/// initialize the event
Expand Down Expand Up @@ -236,11 +241,11 @@ void CSCSimHitMatcher::fitHitsInChamber(unsigned int detid, float& intercept, fl
return;

std::unique_ptr<TGraphErrors> gr(new TGraphErrors(x.size(), &x[0], &y[0], &xe[0], &ye[0]));
std::unique_ptr<TF1> fit(new TF1("fit", "pol1", -3, 4));
gr->Fit("fit", "EMQ");
TF1 fit("fit", "pol1", -3, 4);
gr->Fit(&fit, "EMQN");

intercept = fit->GetParameter(0);
slope = fit->GetParameter(1);
intercept = fit.GetParameter(0);
slope = fit.GetParameter(1);
}

float CSCSimHitMatcher::simHitsMeanStrip(const edm::PSimHitContainer& sim_hits) const {
Expand Down