modernize `CondTools/SiStrip` by mmusich · Pull Request #35415 · cms-sw/cmssw

mmusich · 2021-09-25T12:07:08Z

resolves cms-AlCaDB/AlCaTools#35

PR description:

Migrate away from the deprecated edm::EDAnalyzer API in CondTools/SiStrip and other improvements.

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2021-09-25T12:12:50Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25529/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

mmusich · 2021-09-25T12:21:44Z

@cmsbuild, ping?

mmusich · 2021-09-25T12:21:54Z

code-checks

cmsbuild · 2021-09-25T12:30:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35415/25530

This PR adds an extra 20KB to repository

cmsbuild · 2021-09-25T12:31:01Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondTools/SiStrip (db)

@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-09-25T12:31:25Z

@cmsbuild, please test

cmsbuild · 2021-09-25T16:53:10Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18922/summary.html
COMMIT: b487bca
CMSSW: CMSSW_12_1_X_2021-09-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35415/18922/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18922/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18922/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 40 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3211080
DQMHistoTests: Total failures: 15
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211043
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

tvami · 2021-09-25T16:58:20Z

+db

comparison diffs are in the msg logger only, otherwise all looks good

cmsbuild · 2021-09-25T16:58:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-09-25T19:02:26Z

please test
(to clean up the diff log)

cmsbuild · 2021-09-25T22:03:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cce6af/18924/summary.html
COMMIT: b487bca
CMSSW: CMSSW_12_1_X_2021-09-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35415/18924/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3211080
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3211052
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

tvami · 2021-09-25T22:09:38Z

+db

mmusich · 2021-09-26T10:02:18Z

are now logs clean enough?

perrotta · 2021-09-26T10:16:33Z

+1

modernize CondTools/SiStrip

b487bca

cmsbuild added this to the CMSSW_12_1_X milestone Sep 25, 2021

cmsbuild added code-checks-pending db-pending orp-pending pending-signatures tests-pending labels Sep 25, 2021

mmusich mentioned this pull request Sep 25, 2021

Deprecated Legacy modules in CondTools/SiStrip cms-AlCaDB/AlCaTools#35

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Sep 25, 2021

mmusich force-pushed the modernizeCondToolsSiStrip branch from 0b162a2 to b487bca Compare September 25, 2021 12:16

cmsbuild added code-checks-pending and removed code-checks-rejected labels Sep 25, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 25, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 25, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 25, 2021

cmsbuild removed the db-pending label Sep 25, 2021

cmsbuild removed the pending-signatures label Sep 25, 2021

cmsbuild added db-approved fully-signed labels Sep 25, 2021

cmsbuild added tests-started and removed tests-approved labels Sep 25, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 25, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 26, 2021

cmsbuild merged commit 1bded24 into cms-sw:master Sep 26, 2021

mmusich deleted the modernizeCondToolsSiStrip branch September 26, 2021 11:00

cmsbuild mentioned this pull request Sep 26, 2021

Migrate module config in EventFilter{RPCRawToDigi} to use default cfipython #35419

Merged

Conversation

mmusich commented Sep 25, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Uh oh!

cmsbuild commented Sep 25, 2021

Uh oh!

mmusich commented Sep 25, 2021

Uh oh!

mmusich commented Sep 25, 2021

Uh oh!

cmsbuild commented Sep 25, 2021

Uh oh!

cmsbuild commented Sep 25, 2021

Uh oh!

mmusich commented Sep 25, 2021

Uh oh!

cmsbuild commented Sep 25, 2021

Comparison Summary

Uh oh!

tvami commented Sep 25, 2021

Uh oh!

cmsbuild commented Sep 25, 2021

Uh oh!

perrotta commented Sep 25, 2021

Uh oh!

cmsbuild commented Sep 25, 2021

Comparison Summary

Uh oh!

tvami commented Sep 25, 2021

Uh oh!

mmusich commented Sep 26, 2021

Uh oh!

perrotta commented Sep 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants