-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32278/20066

ERROR: Build errors found during clang-tidy run.

Alignment/TrackerAlignment/plugins/CosmicRateAnalyzer.cc:58:10: error: 'DataFormats/SiPixelDetId/interface/PixelBarrelName.h' file not found [clang-diagnostic-error]
#include "DataFormats/SiPixelDetId/interface/PixelBarrelName.h"
         ^
Suppressed 1624 warnings (1623 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32278/20070

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32278/20070/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32278/20070/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

@saumyaphor4252 thanks for this.
Can you:

• change the title of the PR to something more meaningful (e.g.: Updated CosmicRateAnalyzer: MagField & Hits, deleted latency)
• run the mandatory code-format patches with: scram b code-format in your local checkout and push to this branch?

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32278/20071

• This PR adds an extra 16KB to repository

A new Pull Request was created by @saumyaphor4252 (Saumya) for master.

It involves the following packages:

Alignment/TrackerAlignment

@yuanchao, @christopheralanwest, @tocheng, @cmsbuild, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild, please test

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-11-24-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/11024/console Started: 2020/11/25 10:57

+1
Tested at: 42d3496
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b86673/11024/summary.html
CMSSW: CMSSW_11_2_X_2020-11-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

Comparison job queued.

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b86673/11024/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2274 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2963516
• DQMHistoTests: Total failures: 5549
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2957945
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 158 log files, 34 edm output root files, 37 DQM output files

@yuanchao, @christopheralanwest
would it be possible to process the review of this PR at earliest convenience, such at I can rebase #32301 once this is merged?
Thanks!

+1

• Only differences seen in comparison tests are for workflow 11642.911, which have been seen in other PRs and are unrelated to the changes introduced in this PR
• Deprecated method for accessing EventSetup will be corrected in a dedicated followup PR, migrate Alignment/TrackerAlignment to use esConsumes #32301

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

+1