test materialBudgetHGCalPlots had ERRORS

[silviodonato]

===== Test "materialBudgetHGCalPlots" ====
+ geom=Extended2026D71
+ VGEO_DIR=/data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry
+ TEST_DIR=/data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots
+ '[' -d /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots ']'
+ mkdir /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots
+ cd /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry/test/materialBudgetHGCalPlots
+ cmsRun /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry/test/single_neutrino_cfg.py nEvents=1
+ python /data/cmsbld/jenkins/workspace/ib-run-qa/CMSSW_11_3_X_2021-04-01-1100/src/Validation/Geometry/test/runP_HGCal_cfg.py geom=Extended2026D71 label=HGCal

---> test materialBudgetHGCalPlots had ERRORS
 
^^^^ End Test materialBudgetHGCalPlots ^^^^

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_11_3_X_2021-04-01-1100/unitTestLogs/Validation/Geometry#/12-12

We are getting this error since CMSSW_11_3_X_2021-04-01-1100 because of #33293 from srimanob: Cleaning up obsolete Phase-2 geometries

[silviodonato]

assign upgrade

[cmsbuild]

New categories assigned: upgrade

@kpedro88,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @silviodonato Silvio Donato.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[silviodonato]

The origin of the error is here https://github.com/cms-sw/cmssw/blob/master/Validation/Geometry/test/genHGCalPlots.sh#L3.
D71 has been deleted by #33293, so the unit test needs to be moved to another geometry.
I see that a lot of test code in HGCal needs to be moved away from D71 https://cmssdt.cern.ch/lxr/search?v=CMSSW_11_3_X_2021-03-31-2300&_string=2026D71&%21v=CMSSW_11_3_X_2021-04-01-2300

@srimanob @rovere @felicepantaleo could you take care of it?

[srimanob]

Hi @silviodonato
Do you mean updating the file should be enough? I can take care of it.

[silviodonato]

Yes, thanks.

For the longer term we should also update

Geometry/HGCalCommonData/test/python/testHGCGeometry_cfg.py
Geometry/HGCalCommonData/test/python/testHGCalParametersDDD_cfg.py
Geometry/HGCalGeometry/test/python/hgcGeomAnalyzer_cfg.py
Geometry/HGCalGeometry/test/python/runCaloCellGeometryTest_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalCellDumpDD4Hep_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalCellDumpDDD_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalGeomLocatorSc_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalGeomLocator_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalGeometryCheck_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalGeometry_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalNeighbor_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalRecHitTool_cfg.py
Geometry/HGCalGeometry/test/python/testHGCalWafer_cfg.py
SimG4CMS/Calo/test/python/runHGC3_cfg.py
SimG4CMS/Calo/test/python/runHGC4_cfg.py
Validation/Geometry/test/genHGCalPlots.sh
Validation/HGCalValidation/scripts/hgcalPerformanceValidation.py
Validation/HGCalValidation/test/python/protoHGCalSimWatcher_cfg.py
Validation/HGCalValidation/test/python/protoSimValid_cfg.py
Validation/HGCalValidation/test/python/protoValid_cfg.py
Validation/HGCalValidation/test/python/runHGCGeomCheck_cfg.py
Validation/HGCalValidation/test/python/runHGCHitAnalyzer_cfg.py
Validation/HGCalValidation/test/python/runHGCalDigiStudy_cfg.py
Validation/HGCalValidation/test/python/runHGCalHitCalibration_cfg.py
Validation/HGCalValidation/test/python/runHGCalRecHitStudy_cfg.py
Validation/HGCalValidation/test/python/runHGCalSimHitStudy_cfg.py
Validation/HGCalValidation/test/python/runHGCalWaferHitCheck_cfg.py
Validation/HGCalValidation/test/python/runHGCalWaferStudy_cfg.py
Validation/HGCalValidation/test/python/testHGCalBHValid_cfg.py
Validation/HGCalValidation/test/python/testHGCalSimHitStudy_cfg.py
Validation/HGCalValidation/test/python/testHGCalSimWatcherV14_cfg.py

I hope it is sufficient to replace the string 2026D71 with another geometry, but let's wait for the feedback from HGCal

[srimanob]

OK, Thanks.
I put the one needed of unit test first, #33326

[kpedro88]

@silviodonato we typically do not maintain code in the test area that is not used for unit tests

[srimanob]

+Upgrade

As the unit test is now OK.

[cmsbuild]

This issue is fully signed and ready to be closed.