Show which packages triggered addition of new categories #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
A new Pull Request was created by @iarspider for branch master. @akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. |
Contributor
|
cms-bot internal usage |
Contributor
|
Pull request #2601 was updated. |
iarspider
force-pushed
the
why-new-categories-v2
branch
from
1fa2355 to
2b489d6
Compare
Contributor
|
Pull request #2601 was updated. |
smuzaffar
reviewed
Oct 27, 2025
| old_packages.update(cmssw_file2Package(repo_config, f) for f in commit["files"]) | ||
| else: | ||
| old_packages = {"externals/" + repository} | ||
|
|
Contributor
There was a problem hiding this comment.
@iarspider , looks like it is still not getting all the files e.g. for cms-sw/cmssw#48861 github tells that there are 21 files but if I printout the unique files names here then I get this
Unique files: 20
list of files:
Calibration/LumiAlCaRecoProducers/plugins/BuildFile.xml
Calibration/LumiAlCaRecoProducers/plugins/DynamicVetoProducer.cc
Calibration/LumiAlCaRecoProducers/plugins/RawPCCProducerDynVeto.cc
Calibration/LumiAlCaRecoProducers/python/test_hlt.py
Calibration/LumiAlCaRecoProducers/python/test_hlt_2.py
Calibration/LumiAlCaRecoProducers/python/test_hlt_2_old.py
Calibration/LumiAlCaRecoProducers/python/test_hlt_3.py
CondFormats/DataRecord/interface/PccVetoListRcd.h
CondFormats/DataRecord/src/PccVetoListRcd.cc
CondFormats/Luminosity/interface/PccVetoList.h
CondFormats/Luminosity/src/T_EventSetup_PccVetoList.cc
CondFormats/Luminosity/src/classes_def.xml
CondFormats/Luminosity/src/headers.h
Configuration/Geometry/README.md
Configuration/Geometry/python/dict2021Geometry.py
Configuration/StandardSequences/python/GeometryConf.py
GeneratorInterface/LHEInterface/data/run_generic_tarball_cvmfs.sh
Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2025.xml
Geometry/CMSCommonData/python/cmsExtendedGeometry2025XML_cfi.py
L1Trigger/L1TGlobal/plugins/L1TGlobalProducer.cc
Contributor
|
-externals looks like it is missing to process all the files e.g see the comment #2601 (comment) |
Contributor
|
ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2481. Also did some minor improvements to code readability.
Redo of #2599 without changing bot cache