Version of the HTT and HTM with an eta cut#7
Open
mark-grimes wants to merge 4 commits intocms-l1trigger-menustudies:masterfrom
Open
Version of the HTT and HTM with an eta cut#7mark-grimes wants to merge 4 commits intocms-l1trigger-menustudies:masterfrom
mark-grimes wants to merge 4 commits intocms-l1trigger-menustudies:masterfrom
Conversation
Contributor
|
Mark, |
Author
|
Yes, should be quite trivial. Testing will be more work than making the change. |
Author
|
Added pT cuts. Still needs testing. Also, the pT cut can currently only be set using an input XML menu file. The menu fit currently can't use those though. The pT cut can be set with a "ptCut" parameter, e.g.: Note the "formatVersion" attribute is a flag to allow the information layout to change. The "version" tag sets the version of the trigger used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've not tested these yet. I put the pull request in first to aid discussion.
This doesn't overwrite the old triggers but it makes the new ones the default - only xml menu files can use non-default versions and the fit doesn't work with xml files. As such I would not recommend merging until a full comparison has been made.