Code sniff warnings

[DamianZaremba]

Need to cleanup and/or decide on policy:

FILE: /mnt/includes/dbFunctions.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 17 and the first
   |         | side effect is on line 3.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/includes/Page.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 29 | WARNING | Line exceeds 120 characters; contains 127 characters
----------------------------------------------------------------------


FILE: /mnt/scripts/backfill_edits_sent_for_review.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 27 | WARNING | Line exceeds 120 characters; contains 152 characters
----------------------------------------------------------------------


FILE: /mnt/api/modules/edits_get.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first
    |         | side effect is on line 90.
 65 | WARNING | Line exceeds 120 characters; contains 149 characters
 73 | WARNING | Line exceeds 120 characters; contains 152 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/reports_list.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first
    |         | side effect is on line 61.
 45 | WARNING | Line exceeds 120 characters; contains 162 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/reports_get.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first
    |         | side effect is on line 58.
 44 | WARNING | Line exceeds 120 characters; contains 156 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/review_export_user.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 10 and the first
   |         | side effect is on line 35.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/review_export.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first
    |         | side effect is on line 39.
 26 | WARNING | Line exceeds 120 characters; contains 126 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/help.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 10 and the first
   |         | side effect is on line 74.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/health_check.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 10 and the first
   |         | side effect is on line 18.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/edits_list.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first
    |         | side effect is on line 101.
 28 | WARNING | Line exceeds 120 characters; contains 121 characters
 77 | WARNING | Line exceeds 120 characters; contains 149 characters
 85 | WARNING | Line exceeds 120 characters; contains 152 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/api/modules/review_import.module.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 9 and the first
    |         | side effect is on line 75.
 31 | WARNING | Line exceeds 120 characters; contains 122 characters
 34 | WARNING | Line exceeds 120 characters; contains 171 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/Options.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
    |         | side effect is on line 76.
 62 | WARNING | Line exceeds 120 characters; contains 130 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/Main.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
    |         | side effect is on line 50.
 24 | WARNING | Line exceeds 120 characters; contains 210 characters
 28 | WARNING | Line exceeds 120 characters; contains 230 characters
 34 | WARNING | Line exceeds 120 characters; contains 229 characters
 38 | WARNING | Line exceeds 120 characters; contains 230 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/View.tpl.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
  17 | WARNING | Line exceeds 120 characters; contains 149 characters
  53 | WARNING | Line exceeds 120 characters; contains 132 characters
  57 | WARNING | Line exceeds 120 characters; contains 131 characters
  61 | WARNING | Line exceeds 120 characters; contains 149 characters
  65 | WARNING | Line exceeds 120 characters; contains 127 characters
 125 | WARNING | Line exceeds 120 characters; contains 137 characters
----------------------------------------------------------------------


FILE: /mnt/pages/SignIn.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 10 and the first
    |         | side effect is on line 142.
 15 | WARNING | Line exceeds 120 characters; contains 121 characters
 45 | WARNING | Line exceeds 120 characters; contains 178 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/SignOut.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
   |         | side effect is on line 26.
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/View.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
    |         | side effect is on line 82.
 15 | WARNING | Line exceeds 120 characters; contains 153 characters
 20 | WARNING | Line exceeds 120 characters; contains 161 characters
 50 | WARNING | Line exceeds 120 characters; contains 162 characters
 52 | WARNING | Line exceeds 120 characters; contains 124 characters
 65 | WARNING | Line exceeds 120 characters; contains 153 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/Report.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
    |         | side effect is on line 64.
 27 | WARNING | Line exceeds 120 characters; contains 144 characters
 41 | WARNING | Line exceeds 120 characters; contains 136 characters
 45 | WARNING | Line exceeds 120 characters; contains 136 characters
 53 | WARNING | Line exceeds 120 characters; contains 145 characters
 55 | WARNING | Line exceeds 120 characters; contains 339 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/List.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
    |         | side effect is on line 54.
 20 | WARNING | Line exceeds 120 characters; contains 133 characters
 45 | WARNING | Line exceeds 120 characters; contains 123 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /mnt/pages/UserAdminPage.page.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 5 and the first
    |         | side effect is on line 84.
 20 | WARNING | Line exceeds 120 characters; contains 161 characters
 21 | WARNING | Line exceeds 120 characters; contains 168 characters
 22 | WARNING | Line exceeds 120 characters; contains 145 characters
 36 | WARNING | Line exceeds 120 characters; contains 153 characters
 67 | WARNING | Line exceeds 120 characters; contains 142 characters
 68 | WARNING | Line exceeds 120 characters; contains 147 characters
 69 | WARNING | Line exceeds 120 characters; contains 141 characters
 70 | WARNING | Line exceeds 120 characters; contains 134 characters
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 769ms; Memory: 8MB

[methecooldude]

The lines being "too long", don't really care... what's your opinion?

[DamianZaremba]

The lines being "too long", don't really care... what's your opinion?

Normally I use 120 (in Python projects), but I'm not too fussed, especially since there is no auto formatter such as black here.

After 18db45a this isn't failing CI anymore so is mostly just a tidy up job... the default policy is being used at the moment.

[DamianZaremba]

Currently (excluding those about line length:

FILE: /home/runner/work/report/report/api/modules/review_export.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 9 and the first side effect is
   |         | on line 41.
Time: 603ms; Memory: 8MB
--------------------------------------------------------------------------------

FILE: /home/runner/work/report/report/api/modules/metrics.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions,
    |         | constants, etc.) and cause no other side effects, or it should
    |         | execute logic with side effects, but should not do both. The
    |         | first symbol is defined on line 10 and the first side effect is
    |         | on line 52.

FILE: /home/runner/work/report/report/api/modules/help.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 10 and the first side effect is
   |         | on line 74.
--------------------------------------------------------------------------------


FILE: /home/runner/work/report/report/api/modules/review_export_user.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 10 and the first side effect is
   |         | on line 35.
--------------------------------------------------------------------------------


FILE: /home/runner/work/report/report/api/modules/reports_get.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 9 and the first side effect is
   |         | on line 75.
--------------------------------------------------------------------------------


FILE: /home/runner/work/report/report/api/modules/reports_list.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 9 and the first side effect is
   |         | on line 80.
--------------------------------------------------------------------------------

FILE: /home/runner/work/report/report/api/modules/health_check.module.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 10 and the first side effect is
   |         | on line 18.
--------------------------------------------------------------------------------

FILE: /home/runner/work/report/report/pages/SignOut.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 5 and the first side effect is
   |         | on line 26.
--------------------------------------------------------------------------------

FILE: /home/runner/work/report/report/pages/SignIn.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 10 and the first side effect is
   |         | on line 129.
--------------------------------------------------------------------------------

FILE: /home/runner/work/report/report/pages/UserAdminPage.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions,
    |         | constants, etc.) and cause no other side effects, or it should
    |         | execute logic with side effects, but should not do both. The
    |         | first symbol is defined on line 5 and the first side effect is
    |         | on line 84.

FILE: /home/runner/work/report/report/pages/Report.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions,
    |         | constants, etc.) and cause no other side effects, or it should
    |         | execute logic with side effects, but should not do both. The
    |         | first symbol is defined on line 5 and the first side effect is
    |         | on line 85.

FILE: /home/runner/work/report/report/pages/View.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions,
    |         | constants, etc.) and cause no other side effects, or it should
    |         | execute logic with side effects, but should not do both. The
    |         | first symbol is defined on line 5 and the first side effect is
    |         | on line 82.

FILE: /home/runner/work/report/report/pages/List.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions,
    |         | constants, etc.) and cause no other side effects, or it should
    |         | execute logic with side effects, but should not do both. The
    |         | first symbol is defined on line 5 and the first side effect is
    |         | on line 73.

FILE: /home/runner/work/report/report/pages/Main.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
  1 | WARNING | A file should declare new symbols (classes, functions,
    |         | constants, etc.) and cause no other side effects, or it should
    |         | execute logic with side effects, but should not do both. The
    |         | first symbol is defined on line 5 and the first side effect is
    |         | on line 50.

FILE: /home/runner/work/report/report/pages/Options.page.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions,
   |         | constants, etc.) and cause no other side effects, or it should
   |         | execute logic with side effects, but should not do both. The
   |         | first symbol is defined on line 5 and the first side effect is
   |         | on line 77.
--------------------------------------------------------------------------------