Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractor will never run #21

Open
robkooper opened this issue Oct 5, 2020 · 2 comments
Open

extractor will never run #21

robkooper opened this issue Oct 5, 2020 · 2 comments
Assignees

Comments

@robkooper
Copy link
Member

robkooper commented Oct 5, 2020

if the resource or the host is not correctly computed, the extractor will never start, but also not ack the messages, resulting in the extractor being stuck.

See the following places:

logging.error("Host is empty, this is bad.")

logging.error("No resource found, this is bad.")

In this case all we can do is move the message to the error queue and ack it. It is not possible to send an update to clowder.

@max-zilla
Copy link
Contributor

Started an implementation of this here:
https://github.com/clowder-framework/pyclowder/compare/fail-gracefully-on-bad-resources

Haven't tested it yet but tried to make it generically adaptable for other connectors as well.

@robkooper
Copy link
Member Author

@max-zilla looks good sofar, next comes testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants