support type key for CodeBuild environment variables (#88)

joe-niland · cloudpossebot · web-flow · commit f2c178bb834f · 2021-04-22T10:41:17.000-06:00
Co-authored-by: cloudpossebot &lt;11232728+cloudpossebot@users.noreply.github.com&gt;
diff --git a/README.md b/README.md
diff --git a/docs/terraform.md b/docs/terraform.md
diff --git a/examples/complete/fixtures.us-east-2.tfvars b/examples/complete/fixtures.us-east-2.tfvars
@@ -12,15 +12,17 @@ environment_variables = [
   {
     name  = "APP_URL"
     value = "https://app.example.com"
+    type  = "PLAINTEXT"
   },
   {
     name  = "COMPANY_NAME"
     value = "Cloud Posse"
+    type  = "PLAINTEXT"
   },
   {
     name  = "TIME_ZONE"
     value = "America/Los_Angeles"
-
+    type  = "PLAINTEXT"
   }
 ]
 
diff --git a/examples/complete/variables.tf b/examples/complete/variables.tf
@@ -8,15 +8,17 @@ variable "environment_variables" {
     {
       name  = string
       value = string
+      type  = string
   }))
 
   default = [
     {
       name  = "NO_ADDITIONAL_BUILD_VARS"
       value = "TRUE"
+      type  = "PLAINTEXT"
   }]
 
-  description = "A list of maps, that contain both the key 'name' and the key 'value' to be used as additional environment variables for the build"
+  description = "A list of maps, that contain the keys 'name', 'value', and 'type' to be used as additional environment variables for the build. Valid types are 'PLAINTEXT', 'PARAMETER_STORE', or 'SECRETS_MANAGER'"
 }
 
 variable "cache_expiration_days" {
diff --git a/examples/vpc/fixtures.us-east-2.tfvars b/examples/vpc/fixtures.us-east-2.tfvars
@@ -16,15 +16,17 @@ environment_variables = [
   {
     name  = "APP_URL"
     value = "https://app.example.com"
+    type  = "PLAINTEXT"
   },
   {
     name  = "COMPANY_NAME"
     value = "Cloud Posse"
+    type  = "PLAINTEXT"
   },
   {
     name  = "TIME_ZONE"
     value = "America/Los_Angeles"
-
+    type  = "PLAINTEXT"
   }
 ]
 
diff --git a/examples/vpc/variables.tf b/examples/vpc/variables.tf
@@ -18,15 +18,17 @@ variable "environment_variables" {
     {
       name  = string
       value = string
+      type  = string
   }))
 
   default = [
     {
       name  = "NO_ADDITIONAL_BUILD_VARS"
       value = "TRUE"
+      type  = "PLAINTEXT"
   }]
 
-  description = "A list of maps, that contain both the key 'name' and the key 'value' to be used as additional environment variables for the build"
+  description = "A list of maps, that contain the keys 'name', 'value', and 'type' to be used as additional environment variables for the build. Valid types are 'PLAINTEXT', 'PARAMETER_STORE', or 'SECRETS_MANAGER'"
 }
 
 variable "cache_expiration_days" {
diff --git a/main.tf b/main.tf
@@ -390,6 +390,7 @@ resource "aws_codebuild_project" "default" {
       content {
         name  = environment_variable.value.name
         value = environment_variable.value.value
+        type  = environment_variable.value.type
       }
     }
 
diff --git a/variables.tf b/variables.tf
@@ -3,15 +3,17 @@ variable "environment_variables" {
     {
       name  = string
       value = string
+      type  = string
   }))
 
   default = [
     {
       name  = "NO_ADDITIONAL_BUILD_VARS"
       value = "TRUE"
+      type  = "PLAINTEXT"
   }]
 
-  description = "A list of maps, that contain both the key 'name' and the key 'value' to be used as additional environment variables for the build"
+  description = "A list of maps, that contain the keys 'name', 'value', and 'type' to be used as additional environment variables for the build. Valid types are 'PLAINTEXT', 'PARAMETER_STORE', or 'SECRETS_MANAGER'"
 }
 
 variable "cache_expiration_days" {

Original file line number	Diff line number	Diff line change
`@@ -12,15 +12,17 @@ environment_variables = [`
`12`	`12`	`{`
`13`	`13`	`name = "APP_URL"`
`14`	`14`	`value = "https://app.example.com"`
	`15`	`+ type = "PLAINTEXT"`
`15`	`16`	`},`
`16`	`17`	`{`
`17`	`18`	`name = "COMPANY_NAME"`
`18`	`19`	`value = "Cloud Posse"`
	`20`	`+ type = "PLAINTEXT"`
`19`	`21`	`},`
`20`	`22`	`{`
`21`	`23`	`name = "TIME_ZONE"`
`22`	`24`	`value = "America/Los_Angeles"`
`23`		`-`
	`25`	`+ type = "PLAINTEXT"`
`24`	`26`	`}`
`25`	`27`	`]`
`26`	`28`
Original file line number	Diff line number	Diff line change
`@@ -8,15 +8,17 @@ variable "environment_variables" {`
`8`	`8`	`{`
`9`	`9`	`name = string`
`10`	`10`	`value = string`
	`11`	`+ type = string`
`11`	`12`	`}))`
`12`	`13`
`13`	`14`	`default = [`
`14`	`15`	`{`
`15`	`16`	`name = "NO_ADDITIONAL_BUILD_VARS"`
`16`	`17`	`value = "TRUE"`
	`18`	`+ type = "PLAINTEXT"`
`17`	`19`	`}]`
`18`	`20`
`19`		`- description = "A list of maps, that contain both the key 'name' and the key 'value' to be used as additional environment variables for the build"`
	`21`	`+ description = "A list of maps, that contain the keys 'name', 'value', and 'type' to be used as additional environment variables for the build. Valid types are 'PLAINTEXT', 'PARAMETER_STORE', or 'SECRETS_MANAGER'"`
`20`	`22`	`}`
`21`	`23`
`22`	`24`	`variable "cache_expiration_days" {`
Original file line number	Diff line number	Diff line change
`@@ -16,15 +16,17 @@ environment_variables = [`
`16`	`16`	`{`
`17`	`17`	`name = "APP_URL"`
`18`	`18`	`value = "https://app.example.com"`
	`19`	`+ type = "PLAINTEXT"`
`19`	`20`	`},`
`20`	`21`	`{`
`21`	`22`	`name = "COMPANY_NAME"`
`22`	`23`	`value = "Cloud Posse"`
	`24`	`+ type = "PLAINTEXT"`
`23`	`25`	`},`
`24`	`26`	`{`
`25`	`27`	`name = "TIME_ZONE"`
`26`	`28`	`value = "America/Los_Angeles"`
`27`		`-`
	`29`	`+ type = "PLAINTEXT"`
`28`	`30`	`}`
`29`	`31`	`]`
`30`	`32`
Original file line number	Diff line number	Diff line change
`@@ -18,15 +18,17 @@ variable "environment_variables" {`
`18`	`18`	`{`
`19`	`19`	`name = string`
`20`	`20`	`value = string`
	`21`	`+ type = string`
`21`	`22`	`}))`
`22`	`23`
`23`	`24`	`default = [`
`24`	`25`	`{`
`25`	`26`	`name = "NO_ADDITIONAL_BUILD_VARS"`
`26`	`27`	`value = "TRUE"`
	`28`	`+ type = "PLAINTEXT"`
`27`	`29`	`}]`
`28`	`30`
`29`		`- description = "A list of maps, that contain both the key 'name' and the key 'value' to be used as additional environment variables for the build"`
	`31`	`+ description = "A list of maps, that contain the keys 'name', 'value', and 'type' to be used as additional environment variables for the build. Valid types are 'PLAINTEXT', 'PARAMETER_STORE', or 'SECRETS_MANAGER'"`
`30`	`32`	`}`
`31`	`33`
`32`	`34`	`variable "cache_expiration_days" {`
Original file line number	Diff line number	Diff line change
`@@ -390,6 +390,7 @@ resource "aws_codebuild_project" "default" {`
`390`	`390`	`content {`
`391`	`391`	`name = environment_variable.value.name`
`392`	`392`	`value = environment_variable.value.value`
	`393`	`+ type = environment_variable.value.type`
`393`	`394`	`}`
`394`	`395`	`}`
`395`	`396`
Original file line number	Diff line number	Diff line change
`@@ -3,15 +3,17 @@ variable "environment_variables" {`
`3`	`3`	`{`
`4`	`4`	`name = string`
`5`	`5`	`value = string`
	`6`	`+ type = string`
`6`	`7`	`}))`
`7`	`8`
`8`	`9`	`default = [`
`9`	`10`	`{`
`10`	`11`	`name = "NO_ADDITIONAL_BUILD_VARS"`
`11`	`12`	`value = "TRUE"`
	`13`	`+ type = "PLAINTEXT"`
`12`	`14`	`}]`
`13`	`15`
`14`		`- description = "A list of maps, that contain both the key 'name' and the key 'value' to be used as additional environment variables for the build"`
	`16`	`+ description = "A list of maps, that contain the keys 'name', 'value', and 'type' to be used as additional environment variables for the build. Valid types are 'PLAINTEXT', 'PARAMETER_STORE', or 'SECRETS_MANAGER'"`
`15`	`17`	`}`
`16`	`18`
`17`	`19`	`variable "cache_expiration_days" {`