Skip to content

🐛 [BUG shoot grafter] - Events need improvement #12

@uwe-mayer

Description

@uwe-mayer

Priority

None

Description

In events (and probably in logs?): We do not use the identifiers for shoots/clusters consistently. We mix shoot/cluster, which result in different log subjects, as they come from different namespaces (Garden vs Greenhouse cluster).

AND
Currently we emit to many events or we reconcile already created resources:

Events:
  Type     Reason              Age                      From                        Message
  ----     ------              ----                     ----                        -------
  Normal   OIDCConfigured      45m (x8435 over 2d16h)   shoot-controller-***  Successfully configured OIDC authentication for shoot ***
  Warning  RBACCreationFailed  4m21s (x5275 over 2d3h)  shoot-controller-***  Failed to create ClusterRoleBinding greenhouse:system:cluster-admin for shoot ***: failed to get server groups: Get "***": dial tcp 10.219.59.207:443: i/o timeout
  Normal   SecretUpdated       47s (x8451 over 2d16h)   shoot-controller-***  Updated Greenhouse secret *** for shoot *** with API server URL ***

Reproduction steps

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Manifests

apiVersion: greenhouse.sap/v1alpha1
  kind: ...

Screenshots

![DESCRIPTION](LINK.png)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions