Vitest (#92)

# Description

Migrates from Jest to Vitest

## Issue Ticket Number

<!-- Specifiy which issue this fixes by referencing the issue number
(`#11`) or issue URL. -->
<!-- Example: Fixes
#1 -->

Fixes #90 

## Type of change

<!-- Please select all options that are applicable. -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [ ] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [ ] I have created an
[issue](https://github.com/colbyfayock/netlify-plugin-cloudinary/issues)
ticket for this PR
- [ ] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/colbyfayock/netlify-plugin-cloudinary/pulls)
for the same update/change?
- [ ] I have performed a self-review of my own code
- [ ] I have run tests locally to ensure they all pass
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes needed to the documentation

Author: colbyfayock

netlify-plugin-cloudinary/.npmignore

@@ -4,7 +4,6 @@
 .prettierignore
 .prettierrc
 .setTestEnvVars.js
-jest.config.js
 node_modules
 src
 tsconfig.json

netlify-plugin-cloudinary/.setTestEnvVars.js

@@ -9,7 +9,7 @@
     "format": "prettier  --write \"(src|test)/*.+(js|ts|json)\"",
     "postpublish": "rm ./README.md",
     "prepublishOnly": "cp ../README.md . && pnpm build",
-    "test": "jest",
+    "test": "vitest run",
     "typecheck": "tsc --noEmit -p ./tsconfig.json"
   },
   "author": {
@@ -38,9 +38,11 @@
     "eslint-plugin-import": "2.28.1",
     "eslint-plugin-n": "16.0.2",
     "eslint-plugin-promise": "6.1.1",
-    "jest": "29.6.4",
     "prettier": "3.0.3",
-    "ts-jest": "29.1.1",
-    "typescript": "5.2.2"
+    "typescript": "5.2.2",
+    "vitest": "^0.34.6"
+  },
+  "engines": {
+    "node": ">=16"
   }
 }

netlify-plugin-cloudinary/jest.config.js

@@ -1,11 +1,13 @@
-const { configureCloudinary, getCloudinaryUrl, updateHtmlImagesToCloudinary } = require('../../src/lib/cloudinary');
+import { vi, expect, describe, test, beforeEach, afterAll, it } from 'vitest';
+
+import { configureCloudinary, getCloudinaryUrl, updateHtmlImagesToCloudinary } from '../../src/lib/cloudinary';
 
 describe('lib/util', () => {
   const ENV_ORIGINAL = process.env;
   const cname = 'spacejelly.dev';
 
   beforeEach(() => {
-    jest.resetModules();
+    vi.resetModules();
 
     process.env = { ...ENV_ORIGINAL };
     process.env.CLOUDINARY_CLOUD_NAME = 'testcloud';

netlify-plugin-cloudinary/package.json

@@ -1,10 +1,12 @@
-const { configureCloudinary, getCloudinaryUrl, updateHtmlImagesToCloudinary } = require('../../src/lib/cloudinary');
+import { vi, expect, describe, test, beforeEach, afterAll, it } from 'vitest';
+
+import { configureCloudinary, getCloudinaryUrl, updateHtmlImagesToCloudinary } from '../../src/lib/cloudinary';
 
 describe('lib/util', () => {
   const ENV_ORIGINAL = process.env;
 
   beforeEach(() => {
-    jest.resetModules();
+    vi.resetModules();
 
     process.env = { ...ENV_ORIGINAL };
     process.env.CLOUDINARY_CLOUD_NAME = 'testcloud';

netlify-plugin-cloudinary/tests/lib/cloudinary-cname.test.js

@@ -1,5 +1,7 @@
-const { ERROR_ASSET_UPLOAD, ERROR_INVALID_SRCSET } = require('../../src/data/errors');
-const { getCloudinary, createPublicId, getCloudinaryUrl, configureCloudinary, updateHtmlImagesToCloudinary } = require('../../src/lib/cloudinary');
+import { vi, expect, describe, test, beforeEach, afterAll, it } from 'vitest';
+
+import { ERROR_ASSET_UPLOAD } from '../../src/data/errors';
+import { getCloudinary, createPublicId, configureCloudinary, getCloudinaryUrl, updateHtmlImagesToCloudinary } from '../../src/lib/cloudinary';
 
 const mockDemo = require('../mocks/demo.json');
 
@@ -9,7 +11,7 @@ describe('lib/util', () => {
   const ENV_ORIGINAL = process.env;
 
   beforeEach(() => {
-    jest.resetModules();
+    vi.resetModules();
 
     process.env = { ...ENV_ORIGINAL };
     process.env.CLOUDINARY_CLOUD_NAME = 'testcloud';
@@ -73,7 +75,7 @@ describe('lib/util', () => {
 
     test('should create a Cloudinary URL with delivery type of upload from a local image', async () => {
       // mock cloudinary.uploader.upload call
-      cloudinary.uploader.upload = jest.fn().mockResolvedValue({
+      cloudinary.uploader.upload = vi.fn().mockResolvedValue({
         public_id: 'stranger-things-dustin-fc571e771d5ca7d9223a7eebfd2c505d',
         secure_url: `https://res.cloudinary.com/${process.env.CLOUDINARY_CLOUD_NAME}/image/upload/v1613009008/stranger-things-dustin-fc571e771d5ca7d9223a7eebfd2c505d.jpg`,
         original_filename: 'stranger-things-dustin',
@@ -97,7 +99,7 @@ describe('lib/util', () => {
 
     test('should fail to create a Cloudinary URL with delivery type of upload', async () => {
       // mock cloudinary.uploader.upload call
-      cloudinary.uploader.upload = jest.fn().mockImplementation(() => Promise.reject('error'))
+      cloudinary.uploader.upload = vi.fn().mockImplementation(() => Promise.reject('error'))
 
 
       await expect(getCloudinaryUrl({

netlify-plugin-cloudinary/tests/lib/cloudinary-privatecdn.test.js

@@ -1,4 +1,6 @@
-const { isRemoteUrl, determineRemoteUrl, getQueryParams } = require('../../src/lib/util');
+import { expect, describe, test } from 'vitest';
+
+import { isRemoteUrl, determineRemoteUrl, getQueryParams } from '../../src/lib/util';
 
 describe('lib/util', () => {
 

netlify-plugin-cloudinary/tests/lib/cloudinary.test.js

@@ -1,14 +1,15 @@
-const fs = require('fs').promises;
-const { onBuild } = require('../src/');
-const { ERROR_API_CREDENTIALS_REQUIRED } = require('../src/data/errors');
+import { vi, expect, describe, test, beforeEach,afterEach } from 'vitest';
+import { promises as fs } from 'fs';
+import { onBuild } from '../src/';
+import { ERROR_API_CREDENTIALS_REQUIRED } from '../src/data/errors';
 
 describe('onBuild', () => {
   const ENV_ORIGINAL = process.env;
   const readdir = fs.readdir;
 
   beforeEach(() => {
-    fs.readdir = jest.fn();
-    jest.resetModules();
+    fs.readdir = vi.fn();
+    vi.resetModules();
 
     process.env = { ...ENV_ORIGINAL };
 
@@ -31,7 +32,7 @@ describe('onBuild', () => {
       // We don't need a "special" test for this as it's default functionality that should work with
       // any valid test, so we can isntead ensure the keys don't exist and delete them
 
-      jest.spyOn(global.console, 'error').mockImplementation();
+      vi.spyOn(global.console, 'error').mockImplementation();
 
       delete process.env.CLOUDINARY_API_KEY;
       delete process.env.CLOUDINARY_API_SECRET;

netlify-plugin-cloudinary/tests/lib/util.test.js

@@ -1,18 +1,20 @@
-const fs = require('fs').promises;
-const path = require('path');
-const { JSDOM } = require('jsdom');
-
-const { onPostBuild } = require('../src/');
+import { vi, expect, describe, test, beforeAll, afterAll, beforeEach, afterEach } from 'vitest';
+import { promises as fs } from 'fs';
+import path from 'path';
+import { JSDOM } from 'jsdom';
+import { onPostBuild } from '../src/';
 
 const mocksPath = path.join(__dirname, 'mocks/html');
 const tempPath = path.join(mocksPath, 'temp');
 
 async function mkdir(directoryPath) {
   let dir;
+  console.log('directoryPath', directoryPath)
   try {
     dir = await fs.stat(directoryPath);
   } catch(e) {}
   if ( dir && dir.isDirectory() ) return;
+  console.log('mkdir')
   await fs.mkdir(directoryPath);
 }
 
@@ -24,7 +26,7 @@ describe('onPostBuild', () => {
   });
 
   beforeEach(async () => {
-    jest.resetModules();
+    vi.resetModules();
 
     process.env = { ...ENV_ORIGINAL };
 
@@ -34,7 +36,7 @@ describe('onPostBuild', () => {
     process.env.CLOUDINARY_API_SECRET = 'abcd1234';
 
     const mockFiles = (await fs.readdir(mocksPath)).filter(filePath => filePath.includes('.html'));
-    const tempTestPath = path.join(tempPath, expect.getState().currentTestName);
+    const tempTestPath = path.join(tempPath, expect.getState().currentTestName.replace('/', '_'));
     await mkdir(tempTestPath);
     await Promise.all(mockFiles.map(async file => {
       await fs.copyFile(path.join(mocksPath, file), path.join(tempTestPath, file));
@@ -44,7 +46,7 @@ describe('onPostBuild', () => {
   afterEach(async () => {
     process.env = ENV_ORIGINAL;
 
-    await fs.rm(path.join(tempPath, expect.getState().currentTestName), { recursive: true, force: true });
+    await fs.rm(path.join(tempPath, expect.getState().currentTestName.replace('/', '_')), { recursive: true, force: true });
   });
 
   afterAll(async () => {
@@ -64,7 +66,7 @@ describe('onPostBuild', () => {
 
       const deliveryType = 'fetch';
 
-      const tempTestPath = path.join(tempPath, expect.getState().currentTestName);
+      const tempTestPath = path.join(tempPath, expect.getState().currentTestName.replace('/', '_'));
 
       await onPostBuild({
         constants: {
@@ -103,7 +105,7 @@ describe('onPostBuild', () => {
 
       const deliveryType = 'fetch';
 
-      const tempTestPath = path.join(tempPath, expect.getState().currentTestName);
+      const tempTestPath = path.join(tempPath, expect.getState().currentTestName.replace('/', '_'));
 
       const maxSize = {
         width: 800,