Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help **fog-azure-rm** upgrade (or pin) **azure-storage** #2197

Closed
Tracked by #2623
sethboyles opened this issue Apr 19, 2021 · 6 comments
Closed
Tracked by #2623

Help **fog-azure-rm** upgrade (or pin) **azure-storage** #2197

sethboyles opened this issue Apr 19, 2021 · 6 comments

Comments

@sethboyles
Copy link
Member

In response to the Azure regression introduced in https://github.com/cloudfoundry/capi-release/releases/tag/1.97.0

The Situation

  1. CC uses fog-azure-rm for communicating with Azure blobstores
  2. fog-azure-rm uses azure-storage under the hood
  3. azure-storage has a bug between 0.15.0.preview and 1.1.0 that breaks resource matching
  4. We use a cf-specific branch of fog-azure-rm
  5. That branch depends on azure-storage < 1.0, so Bundler keeps trying to upgrade azure-storage to 0.15.0.preview (which has the bug)
  6. Master of fog-azure-rm is pinned to an even older version of azure-storage

To Do
Ideally bundler (and dependabot) shouldn't try to upgrade us to a broken version of fog-azure-rm. It would also be cool if in the future we could move to newer versions of fog-azure-rm and azure-storage for new features and security fixes.

Some possible paths forward:

  1. Move to the mainline releases of fog-azure-rm, assuming it has the features we need from our special branch
  2. Convince the fog-azure-rm maintainers to pin fog-storage on our special branch to a version < 0.15.0.preview
  3. Convince the fog-azure-rm maintainers to bump fog-storage on our special branch to a version >= 1.1.0
  4. Some other, even better, plan

Deliverable: One or more of the following:

  1. A github issue against fog-azure-rm
  2. A github PR against fog-azure-rm
  3. A change to the version of the fog-azure-rm that CC uses

Notes:

  1. If relevant, you can deliver this story when the issue or PR is submitted. No need to wait for the issue/PR to be resolved.
  2. There is currently a PR for bumping azure-storage in fog-azure-rm
  3. Related issue: Cf push times out on azure #1846
@sethboyles
Copy link
Member Author

this issue has been migrated from this Tracker story: https://www.pivotaltracker.com/story/show/174179944

Please refer to that story for additional context

@JenGoldstrich
Copy link
Contributor

Current status of this track and next steps forward

@tstannard and I tried to update the fog-azure-rm gem by updating to the newest version of all the sub-dependancies for azure-storage, this resulted in a lot of failing tests and general Chaos®.

Link to fork,

After talking with @jenspinney we have decided that we should is do the minimum bump we can to get the bugfix above.

This should minimize the complexity of the change. The CAPI team will reach out afterwards to the maintainers of this repo again and see if we can get traction on their side.

GitHub issue link

@sethboyles
Copy link
Member Author

@JenGoldstrich @tstannard It seems that fork is private, can you add me and @MarcPaquette as contributors?

@MarcPaquette
Copy link
Contributor

Just a bad link: https://github.com/tstannard/fog-azure-rm

@JenGoldstrich
Copy link
Contributor

Seth and I submitted a PR to fog-azure-rm here to bump to the deps to 1.1, @jenspinney's idea to go from fog-arm-cf .15.preview => 1.1 was the right call!

tjvman added a commit that referenced this issue Jun 7, 2021
Bumping for the changes we submitted in [PR
438](fog/fog-azure-rm#438), which are necessary
for us to bump `fog-core`.

[#2197]

Co-authored-by: Tom Viehman <[email protected]>
Co-authored-by: Teal Stannard <[email protected]>
tjvman added a commit that referenced this issue Jun 8, 2021
This change broke CATS on Azure.

[#2197]

This reverts commit 34881f4.
tjvman added a commit that referenced this issue Jul 6, 2021
Bumping for the changes we submitted in [PR 438](fog/fog-azure-rm#438),
which will enable us to bump `fog-core`.

[#2197]

Co-authored-by: Tom Viehman <[email protected]>
Co-authored-by: Sarah Weinstein <[email protected]>
moleske pushed a commit that referenced this issue Jan 11, 2022
Bumping for the changes we submitted in [PR 438](fog/fog-azure-rm#438),
which will enable us to bump `fog-core`.

[#2197]

Co-authored-by: Tom Viehman <[email protected]>
Co-authored-by: Sarah Weinstein <[email protected]>
moleske pushed a commit that referenced this issue Jan 13, 2022
Bumping for the changes we submitted in [PR 438](fog/fog-azure-rm#438),
which will enable us to bump `fog-core`.

[#2197]

Co-authored-by: Tom Viehman <[email protected]>
Co-authored-by: Sarah Weinstein <[email protected]>
@sethboyles sethboyles mentioned this issue Jan 13, 2022
12 tasks
@sethboyles
Copy link
Member Author

resolved by #2690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants