Skip to content

Commit 8f1fa18

Browse files
committed
Fix missing completion for AppType 'cnb'
Signed-off-by: Marc Khouzam <[email protected]>
1 parent 7ea11c1 commit 8f1fa18

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

command/flag/app_type.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ import flags "github.com/jessevdk/go-flags"
55
type AppType string
66

77
func (AppType) Complete(prefix string) []flags.Completion {
8-
return completions([]string{"buildpack", "docker"}, prefix, false)
8+
return completions([]string{"buildpack", "docker", "cnb"}, prefix, false)
99
}

command/flag/app_type_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,16 @@ var _ = Describe("AppType", func() {
1919

2020
Entry("completes to 'buildpack' when passed 'b'", "b",
2121
[]flags.Completion{{Item: "buildpack"}}),
22+
Entry("completes to 'cnb' when passed 'c'", "c",
23+
[]flags.Completion{{Item: "cnb"}}),
2224
Entry("completes to 'docker' when passed 'd'", "d",
2325
[]flags.Completion{{Item: "docker"}}),
2426
Entry("completes to 'buildpack' when passed 'bU'", "bU",
2527
[]flags.Completion{{Item: "buildpack"}}),
2628
Entry("completes to 'docker' when passed 'Do'", "Do",
2729
[]flags.Completion{{Item: "docker"}}),
28-
Entry("returns 'buildpack' and 'docker' when passed nothing", "",
29-
[]flags.Completion{{Item: "buildpack"}, {Item: "docker"}}),
30+
Entry("returns 'buildpack', 'cnb', and 'docker' when passed nothing", "",
31+
[]flags.Completion{{Item: "buildpack"}, {Item: "docker"}, {Item: "cnb"}}),
3032
Entry("completes to nothing when passed 'wut'", "wut",
3133
[]flags.Completion{}),
3234
)

0 commit comments

Comments
 (0)