Skip to content

Commit b115e02

Browse files
committed
Polishing
[resolves #889, resolves #890]
1 parent b93dc2d commit b115e02

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

cloudfoundry-client/src/main/java/org/cloudfoundry/client/v2/events/_ListEventsRequest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,18 +37,18 @@ abstract class _ListEventsRequest extends PaginatedRequest {
3737
abstract List<String> getActees();
3838

3939
/**
40-
* The organization id
40+
* The organization ids
4141
*/
4242
@FilterParameter("organization_guid")
4343
@Nullable
44-
abstract List<String> getOrganizationId();
44+
abstract List<String> getOrganizationIds();
4545

4646
/**
47-
* The space id
47+
* The space ids
4848
*/
4949
@FilterParameter("space_guid")
5050
@Nullable
51-
abstract List<String> getSpaceId();
51+
abstract List<String> getSpaceIds();
5252

5353
/**
5454
* The timestamps

integration-test/src/test/java/org/cloudfoundry/client/v2/EventsTest.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
import reactor.test.StepVerifier;
3030

3131
import java.time.Duration;
32-
import java.util.concurrent.TimeoutException;
3332

3433
public final class EventsTest extends AbstractIntegrationTest {
3534

@@ -90,13 +89,13 @@ public void listFilterByActee() {
9089
}
9190

9291
@Test
93-
public void listFilterByTimestamp() {
92+
public void listFilterByOrganizationId() {
9493
getFirstEvent(this.cloudFoundryClient)
9594
.then(resource -> Mono.when(
9695
Mono.just(resource),
9796
this.cloudFoundryClient.events()
9897
.list(ListEventsRequest.builder()
99-
.timestamp(ResourceUtils.getEntity(resource).getTimestamp())
98+
.organizationId(ResourceUtils.getEntity(resource).getOrganizationId())
10099
.build())
101100
.flatMapMany(ResourceUtils::getResources)
102101
.next()
@@ -108,13 +107,13 @@ public void listFilterByTimestamp() {
108107
}
109108

110109
@Test
111-
public void listFilterByType() {
110+
public void listFilterBySpaceId() {
112111
getFirstEvent(this.cloudFoundryClient)
113112
.then(resource -> Mono.when(
114113
Mono.just(resource),
115114
this.cloudFoundryClient.events()
116115
.list(ListEventsRequest.builder()
117-
.type(ResourceUtils.getEntity(resource).getType())
116+
.spaceId(ResourceUtils.getEntity(resource).getSpaceId())
118117
.build())
119118
.flatMapMany(ResourceUtils::getResources)
120119
.next()
@@ -126,13 +125,13 @@ public void listFilterByType() {
126125
}
127126

128127
@Test
129-
public void listFilterByOrganizationId(){
128+
public void listFilterByTimestamp() {
130129
getFirstEvent(this.cloudFoundryClient)
131-
.flatMap(resource -> Mono.zip(
130+
.then(resource -> Mono.when(
132131
Mono.just(resource),
133132
this.cloudFoundryClient.events()
134133
.list(ListEventsRequest.builder()
135-
.spaceId(ResourceUtils.getEntity(resource).getOrganizationId())
134+
.timestamp(ResourceUtils.getEntity(resource).getTimestamp())
136135
.build())
137136
.flatMapMany(ResourceUtils::getResources)
138137
.next()
@@ -144,13 +143,13 @@ public void listFilterByOrganizationId(){
144143
}
145144

146145
@Test
147-
public void listFilterBySpaceId() {
146+
public void listFilterByType() {
148147
getFirstEvent(this.cloudFoundryClient)
149-
.flatMap(resource -> Mono.zip(
148+
.then(resource -> Mono.when(
150149
Mono.just(resource),
151150
this.cloudFoundryClient.events()
152151
.list(ListEventsRequest.builder()
153-
.spaceId(ResourceUtils.getEntity(resource).getSpaceId())
152+
.type(ResourceUtils.getEntity(resource).getType())
154153
.build())
155154
.flatMapMany(ResourceUtils::getResources)
156155
.next()

0 commit comments

Comments
 (0)