Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(nodejs-hybrid-app): factor test setup #7628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(nodejs-hybrid-app): factor test setup #7628

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 23, 2024

cleanup test by factoring code


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: test change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing change

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: d581100

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-wrangler-7628

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7628/npm-package-wrangler-7628

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-wrangler-7628 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-workers-bindings-extension-7628 -O ./cloudflare-workers-bindings-extension.0.0.0-vf0a5e28fb.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vf0a5e28fb.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-create-cloudflare-7628 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-kv-asset-handler-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-miniflare-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-pages-shared-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-unenv-preset-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-vitest-pool-workers-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-workers-editor-shared-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-workers-shared-7628
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12470515380/npm-package-cloudflare-workflows-shared-7628

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant