Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrangler): use unenv bulitin dependency resolution #7625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 23, 2024

Reapply of #7541

The initial PR was reverted by #7583

The root caused was fixed in #7614 (via unjs/unenv#378)

/cc @pi0


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: already tested
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no user facing changes

@vicb vicb requested a review from a team as a code owner December 23, 2024 10:50
Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 50b71f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run e2e tests on a PR label Dec 23, 2024
@vicb vicb requested a review from petebacondarwin December 23, 2024 10:50
Copy link
Contributor

github-actions bot commented Dec 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-wrangler-7625

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7625/npm-package-wrangler-7625

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-wrangler-7625 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-workers-bindings-extension-7625 -O ./cloudflare-workers-bindings-extension.0.0.0-v2426fe749.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v2426fe749.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-create-cloudflare-7625 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-kv-asset-handler-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-miniflare-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-pages-shared-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-unenv-preset-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-vitest-pool-workers-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-workers-editor-shared-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-workers-shared-7625
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12469928984/npm-package-cloudflare-workflows-shared-7625

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant