Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set and range filters to filter validation when using Wrangler CLI #7592

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

garrettgu10
Copy link
Contributor

When executing Vectorize query operations through the wrangler CLI, this PR makes it so that the filter validation logic is able to accept filters involving set ($in or $nin) or range(e.g. $lte) queries.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: No changes to e2e tests
  • Public documentation

@garrettgu10 garrettgu10 requested a review from a team as a code owner December 18, 2024 20:19
Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: 7bd6861

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 18, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-wrangler-7592

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7592/npm-package-wrangler-7592

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-wrangler-7592 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-workers-bindings-extension-7592 -O ./cloudflare-workers-bindings-extension.0.0.0-vec8936b3e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vec8936b3e.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-create-cloudflare-7592 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-kv-asset-handler-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-miniflare-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-pages-shared-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-unenv-preset-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-vitest-pool-workers-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-workers-editor-shared-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-workers-shared-7592
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12438388451/npm-package-cloudflare-workflows-shared-7592

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241218.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@garvit-gupta garvit-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems sound. Should be good to go once the github actions comments are resolved and a changeset is added.

@garrettgu10 garrettgu10 force-pushed the ggu/vectorize-in-nin-range-filter-validation branch from 556f57d to e63254e Compare December 20, 2024 19:27
.changeset/lemon-years-sniff.md Outdated Show resolved Hide resolved
@garrettgu10 garrettgu10 force-pushed the ggu/vectorize-in-nin-range-filter-validation branch from e63254e to 7bd6861 Compare December 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants