Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground-preview-worker): ensure OPTIONS raw HTTP requests are fowarded #7149

Closed
wants to merge 4 commits into from

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 1, 2024

Fixes DEVX-1449.

This PR fixes an issue in which the preview worker does not receive an raw OPTIONS request on both Quick Editor or Workers Playground.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no impact to wrangler
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

Copy link

changeset-bot bot commented Nov 1, 2024

⚠️ No Changeset found

Latest commit: 926f3b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 1, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-wrangler-7149

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7149/npm-package-wrangler-7149

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-wrangler-7149 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-create-cloudflare-7149 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-cloudflare-kv-asset-handler-7149
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-miniflare-7149
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-cloudflare-pages-shared-7149
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-cloudflare-vitest-pool-workers-7149
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-cloudflare-workers-editor-shared-7149
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-cloudflare-workers-shared-7149
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11688676869/npm-package-cloudflare-workflows-shared-7149

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung added the playground-worker Bug or feature on the CF Workers Playground Worker label Nov 1, 2024
@edmundhung edmundhung force-pushed the edmundhung/DEVX-1449 branch from 960165d to c9f04dd Compare November 5, 2024 15:47
@edmundhung
Copy link
Member Author

Superseded by #7630

@edmundhung edmundhung closed this Dec 24, 2024
@edmundhung edmundhung deleted the edmundhung/DEVX-1449 branch December 24, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playground-worker Bug or feature on the CF Workers Playground Worker
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant