Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add tests to @cloudflate/unenv-preset #7579

Open
vicb opened this issue Dec 18, 2024 · 0 comments
Open

Test: Add tests to @cloudflate/unenv-preset #7579

vicb opened this issue Dec 18, 2024 · 0 comments
Assignees

Comments

@vicb
Copy link
Contributor

vicb commented Dec 18, 2024

The unenv preset was added to the repo recently.

We need to add tests to the package

As a first step, we can add test to fixtures/nodejs_hybrid_app but we will need to move those tests to @cloudflate/unenv-preset so that we can use:

  • The most recent workerd by setting MINIFLARE_WORKERD_PATH to the workerd from @cloudflate/unenv-preset
  • The dev version of the preset by setting WRANGLER_UNENV_RESOLVE_PATHS to the dev version of the preset

Note from Pete: There is some overlap with the existing tests. We should remove the overlap. Ideally we should run the tests both with the fixtures and the unenv preset updates - this will require to check the workerd version and skip tests requiring a newer workerd that is available when running the fixture tests (unenv-preset might use a newer workerd version than wrangler).

@vicb vicb self-assigned this Dec 18, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 18, 2024
@vicb vicb moved this from Untriaged to Backlog in workers-sdk Dec 18, 2024
@vicb vicb mentioned this issue Dec 18, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant