Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: Logs don't show if assets.directory is set #7397

Closed
vladshcherbin opened this issue Dec 1, 2024 · 5 comments
Closed

🐛 BUG: Logs don't show if assets.directory is set #7397

vladshcherbin opened this issue Dec 1, 2024 · 5 comments
Labels
bug Something that isn't working

Comments

@vladshcherbin
Copy link

Which Cloudflare product(s) does this pertain to?

Workers Runtime, Wrangler

What version(s) of the tool(s) are you using?

3.91.0 [wrangler]

What version of Node are you using?

22.10.0

What operating system and version are you using?

macOS Sequoia 15.1.1

Describe the Bug

Observed behavior

If I set assets.directory in wrangler.json, observability logs stop showing new logs. If I remove the setting, new logs start coming again. Locally with wrangler dev logs show every time.

with assets.directory:

Screenshot 2024-12-01 at 14 26 40

without:

image

test link - https://wrangler-test.spacehub.workers.dev
test link of public file - https://wrangler-test.spacehub.workers.dev/acorn.svg
full application code - https://github.com/vladshcherbin/wrangler-test

Expected behavior

Logs should continue showing in Logs tab

Steps to reproduce

full application code - https://github.com/vladshcherbin/wrangler-test

  1. deploy
  2. open route - see no logs
  3. remove assets.directory in wrangler.json, re-deploy
  4. open route - see logs

Please provide a link to a minimal reproduction

https://github.com/vladshcherbin/wrangler-test

Please provide any relevant error logs

No response

@vladshcherbin vladshcherbin added the bug Something that isn't working label Dec 1, 2024
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 1, 2024
@emily-shen
Copy link
Contributor

Thanks for the report, I can reproduce and we're looking into it!

@emily-shen emily-shen moved this from Untriaged to Backlog in workers-sdk Dec 2, 2024
@emily-shen
Copy link
Contributor

Just to double check, have you definitely been invoking your worker when you’ve got assets? Requests to assets don’t show up on logs, only worker invocations.

Also does running npx wrangler tail when you have assets deployed give you anything?

@vladshcherbin
Copy link
Author

@emily-shen I've recorded requests and tail output - https://youtu.be/b5a66QPmiwg

Both worker requests and asset requests are not logged with assets.directory and both are logged without it. Please check and let me know if any other information or test might needed 🙌

@emily-shen
Copy link
Contributor

Hey @vladshcherbin should be fixed now! Don't think you have to do anything, maybe redeploy? Feel free to follow up though if you have any issues :))

@github-project-automation github-project-automation bot moved this from Backlog to Done in workers-sdk Dec 4, 2024
@vladshcherbin
Copy link
Author

@emily-shen great news, thanks! Yep, I can confirm Logs tab now shows logs even without a redeploy 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that isn't working
Projects
None yet
Development

No branches or pull requests

2 participants