[o11y] Add KV span tags #3261
Open
[o11y] Add KV span tags #3261
+180
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
04c7f43 to
076a736
Compare
fhanau
commented
Dec 20, 2024
| jsg::Optional<kj::OneOf<kj::String, GetOptions>> options, | ||
| CompatibilityFlags::Reader flags) { | ||
| jsg::Promise<KvNamespace::GetResult> KvNamespace::get( | ||
| jsg::Lock& js, kj::String name, jsg::Optional<kj::OneOf<kj::String, GetOptions>> options) { | ||
| return js.evalNow([&] { |
There was a problem hiding this comment.
Not entirely sure if I'm handling async behavior correctly here? With the get/getWithMetadata implementation being moved to getWithMetadataImpl(), is the js.evalNow() closure still needed here? Should there be one added to getWithMetadata()?
js.evalNow
fhanau
commented
Dec 20, 2024
| jsg::Promise<GetResult> get(jsg::Lock& js, | ||
| kj::String name, | ||
| jsg::Optional<kj::OneOf<kj::String, GetOptions>> options, | ||
| CompatibilityFlags::Reader flags); |
There was a problem hiding this comment.
Minor cleanup: compat flags parameter is not needed here, that should simplify the generated code slightly.
fhanau
force-pushed
the
felix/subrequest-client-spans-kv
branch
from
076a736 to
0d0a53f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3256 needs to land first.