Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements Response.replace_body and support for cf opts in Py fetch. #3229

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Implements Response.replace_body and support for cf opts in Py fetch. #3229

merged 1 commit into from
Jan 7, 2025

Conversation

dom96
Copy link
Collaborator

@dom96 dom96 commented Dec 10, 2024

While going through our examples I noticed that these were missing.

@dom96 dom96 requested review from a team as code owners December 10, 2024 17:57
@dom96 dom96 force-pushed the dominik/sdk-example-improvements branch 4 times, most recently from 8039132 to 5854438 Compare January 6, 2025 17:02
@dom96 dom96 changed the title Implements Response.from_response and support for cf opts in Py fetch. Implements Response.replace_body and support for cf opts in Py fetch. Jan 7, 2025
hoodmane
hoodmane approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from a few nits.

@dom96 dom96 force-pushed the dominik/sdk-example-improvements branch 2 times, most recently from ce9a0b7 to 0814bb6 Compare January 7, 2025 11:04
@dom96 dom96 force-pushed the dominik/sdk-example-improvements branch from 0814bb6 to 0481b0f Compare January 7, 2025 14:14
@dom96 dom96 merged commit 8c228f5 into main Jan 7, 2025
12 checks passed
@dom96 dom96 deleted the dominik/sdk-example-improvements branch January 7, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@hoodmane hoodmane hoodmane approved these changes

@fhanau fhanau Awaiting requested review from fhanau fhanau is a code owner automatically assigned from cloudflare/workers-runtime-1

@danlapid danlapid Awaiting requested review from danlapid danlapid is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dom96 @anonrig @hoodmane @danlapid