Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPT: Autogenerate a test case for each test file #3076

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

npaun
Copy link
Member

@npaun npaun commented Nov 7, 2024

Improves the WPT test harness to generate the JS glue code automatically:

  • Every test file will be invoked by the generated -test.js file. This way don't have to manually edit our tests every time WPT adds a new test.
  • Config for the tests is stored in the -test-config.js file. A new ignore: bool option is added to avoid loading test files we know are irrelevant for us.

In addition, we'll now throw an error if any expectedFailures didn't actually occur. This makes it simple to keep test config up to date as we fix compatibility with the WPT tests.

@npaun npaun requested review from jasnell and anonrig November 7, 2024 15:21
@npaun npaun requested review from a team as code owners November 7, 2024 15:21
@npaun npaun mentioned this pull request Nov 7, 2024
8 tasks
@npaun npaun force-pushed the npaun/wpt-test-config branch from bc44728 to 4c4eb9f Compare November 7, 2024 16:40
// Licensed under the Apache 2.0 license found in the LICENSE file or at:
// https://opensource.org/licenses/Apache-2.0

export const config = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this file typescript and make sure this config is properly typed?

@npaun
Copy link
Member Author

npaun commented Nov 19, 2024

Can we merge this as-is and do the TS conversion in a follow-up PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants