Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›/✨ Bug Report/Feature Request β€” Improve/fix inconvenient path quirks in module fallback service (because of leading /s) #2808

Open
dario-piotrowicz opened this issue Sep 26, 2024 · 0 comments

Comments

@dario-piotrowicz
Copy link
Member

As I've been working with the module fallback service I've found three quirks that I had to workaround (in this patch function).

These are all related to leading /s in paths and I believe could/should be addressed in workerd itself without consumers of the service having to deal with them.

The quirks are:

  • the referred/specifier paths that workerd provides to the service always start with /, this can be problematic in windows where absolute paths do not start with / (patch)
  • when returning a redirection (301) result, such needs to start with /, again this is problematic in windows where absolute paths do not start with / (patch)
  • when returning a module (200) result, the name of the module must not include /, that in my opinion is a bizzare/confusing behavior because in all other cases workerd includes leading /s but in this case it actually refuses paths that start with / (patch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant